Skip to content

Commit

Permalink
create-chiselstrike-app: Depend on exact versions
Browse files Browse the repository at this point in the history
Let's depend on exact versions instead of compatible versions to keep
builds reproducible.

The practical reason is that the current `typescript` dependency
installs latest 4.7.2, which fails the build:

ncc: Using typescript@4.7.2 (local user-provided)
Error: Module build failed (from ./node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js):
Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
    at Object.resolveTypeReferenceDirective (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:42530:18)
    at /Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:316837
    at /Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:303785
    at Array.map (<anonymous>)
    at Object.resolveTypeReferenceDirectives (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/loaders/ts-loader.js.cache.js:13:303777)
    at actualResolveTypeReferenceDirectiveNamesWorker (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:116611:163)
    at resolveTypeReferenceDirectiveNamesWorker (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:116911:26)
    at processTypeReferenceDirectives (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:118393:31)
    at findSourceFileWorker (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:118278:21)
    at findSourceFile (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/typescript/lib/typescript.js:118133:26)
    at /Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1770552
    at /Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:374702
    at _done (eval at create (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:9:1)
    at eval (eval at create (/Users/penberg/src/chiselstrike/chiselstrike/packages/create-chiselstrike-app/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:20:75523), <anonymous>:34:22)

As it's still an open issue, we anyway need to avoid that specific
version:

microsoft/TypeScript#49257

But better to just have explicit version numbers to avoid stuff breaking
when our source stays the same.

(cherry picked from commit c2f4748)
  • Loading branch information
penberg committed May 27, 2022
1 parent 9950433 commit 1e15f83
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 50 deletions.
82 changes: 41 additions & 41 deletions packages/create-chiselstrike-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions packages/create-chiselstrike-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@
"dist"
],
"devDependencies": {
"@types/chalk": "^2.2.0",
"@types/cross-spawn": "^6.0.2",
"@types/node": "^17.0.8",
"@vercel/ncc": "^0.33.1",
"commander": "^8.3.0",
"cross-spawn": "^7.0.3",
"rimraf": "^3.0.2",
"typescript": "^4.5.4"
"@types/chalk": "2.2.0",
"@types/cross-spawn": "6.0.2",
"@types/node": "17.0.8",
"@vercel/ncc": "0.33.1",
"commander": "8.3.0",
"cross-spawn": "7.0.3",
"rimraf": "3.0.2",
"typescript": "4.5.4"
},
"engines": {
"node": ">=14.18.0"
},
"dependencies": {
"handlebars": "^4.7.7"
"handlebars": "4.7.7"
}
}

0 comments on commit 1e15f83

Please sign in to comment.