Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chisel restart should probably restart the process #124

Closed
espindola opened this issue Oct 27, 2021 · 0 comments · Fixed by #131
Closed

chisel restart should probably restart the process #124

espindola opened this issue Oct 27, 2021 · 0 comments · Fixed by #131

Comments

@espindola
Copy link
Contributor

I just sent a pull request for restarting deno. That works, but convinced me that our restart infrastructure is too complicated. We should probably really restart the process using nix::unistd::execv or just exit and have chisel start a new chiseld.

A big advantage is that we would be able to use Once or lazy_static. We would also not need to worry about complications around restarting deno with futures pending that are using the old one.

espindola added a commit that referenced this issue Oct 27, 2021
This turns out to be fairly simple.

Fixes #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant