cli/apply: Run "esbuild" without "npx" #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "esbuild" program is a native binary. Let's run it without "npx" to eliminate the Node.js dependency in "chisel apply".
honzasp
reviewed
Sep 22, 2022
| @@ -162,6 +162,17 @@ pub(crate) async fn apply( | |||
| Ok((modules, index_candidates)) | |||
| } | |||
|
|
|||
| fn esbuild<A: AsRef<OsStr>>(args: &[A]) -> Result<tokio::process::Child> { | |||
There was a problem hiding this comment.
Do you think it would be useful to merge esbuild and npx into a single function (run()? command()? execute()?) to make this a bit drier?
glommer
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "esbuild" program is a native binary. Let's run it without "npx" to eliminate the Node.js dependency in "chisel apply".