This repository has been archived by the owner on Oct 17, 2019. It is now read-only.
SwipeThroughStack #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a prop that allows you to swipe through the last element in the stack. Without this, it's impossible to reach the onFinish function for a stack.
This was referenced Mar 7, 2019
chitezh
reviewed
Mar 8, 2019
src/Swiper.js
Outdated
| @@ -540,7 +542,7 @@ export default class SwiperAnimated extends PureComponent { | |||
| rotate = this.pan.x.interpolate({ inputRange: [-400, 0, 400], outputRange: ['-8deg', '0deg', '8deg'] }); | |||
| translateY = this.pan.y; | |||
| translateX = this.pan.x; | |||
| panHandlers = swiper && children.length - 1 !== this.currentIndex[this.guid] ? | |||
| panHandlers = swiper && children.length - 1 !== this.currentIndex[this.guid] || swipeThroughStack ? | |||
There was a problem hiding this comment.
Nice, could you group the conditions in brackets ()
There was a problem hiding this comment.
@chitezh is that better?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a prop that allows you to swipe through the last element in the stack. Without this, it's impossible to reach the onFinish function for a stack.