Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Firefox shadow #201

Closed
equeim opened this issue Jun 5, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@equeim
Copy link

commented Jun 5, 2014

http://itmages.ru/image/view/1703425/7bf40d74
http://itmages.ru/image/view/1703800/2554c05a
Of course, I can disable shadows for Firefox, but it is ugly when all programs have shadows while Firefox doesn't.

@equeim equeim changed the title Incorrect Firefox autoscroll shadow Incorrect Firefox shadow Jun 5, 2014

@equeim

This comment has been minimized.

Copy link
Author

commented Jun 5, 2014

It seems that i found the workaround: include "class_g = 'Firefox' && !window_type *= 'menu'" in your shadow-exclude condition. However I don't think that it is the real solution: other compositors, like compiz or mutter draw firefox shadows correctly without additional configuration.

@equeim

This comment has been minimized.

Copy link
Author

commented Jun 5, 2014

Also this isn't ideal solution. Ugly shadow from site details disappeared, but not from bookmarks menu.
http://itmages.ru/image/view/1703840/9f23213b
http://itmages.ru/image/view/1703843/718742ed

@richardgv

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2014

  1. As I've explained for numerous times... I suppose it would be impractical to draw the correct shadow on irregular shaped ARGB windows because its shape may change on every frame, getting the contour on CPU would be all too costly, and I don't know a way to do it properly on GPU.
  2. You could disable -z (clear-shadow) to get nicer shadow on those windows. Note this may have negative effects on other ARGB windows: Your ARGB terminal might be severely darkened, and some ARGB windows in other shapes might show up with a huge shadow.
  3. Another solution is to use some better rules, like --shadow-exclude "class_g = 'Firefox' && argb".
@equeim

This comment has been minimized.

Copy link
Author

commented Jun 6, 2014

Another solution is to use some better rules, like --shadow-exclude "class_g = 'Firefox' && argb".

Thanks, it solved the problem.
Nevertheless, how it solved in other compositors? I doubt that they use custom rules for firefox.

@richardgv

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2014

Nevertheless, how it solved in other compositors? I doubt that they use custom rules for firefox.

compiz-0.8.8 doesn't draw shadows on any ARGB windows by default (search for DECOR_DISPLAY_OPTION_SHADOW_MATCH in its plugins/decoration.c, at line 1230), but its window decorator may draw shadow unconditionally. In effect, it's similar with --shadow-exclude 'argb && (override_redirect || wmwin)' in compton.

cairo-compmgr does no special treatment on ARGB windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.