Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Firefox shadow #201

Closed
equeim opened this issue Jun 5, 2014 · 11 comments
Closed

Incorrect Firefox shadow #201

equeim opened this issue Jun 5, 2014 · 11 comments

Comments

@equeim
Copy link

equeim commented Jun 5, 2014

http://itmages.ru/image/view/1703425/7bf40d74
http://itmages.ru/image/view/1703800/2554c05a
Of course, I can disable shadows for Firefox, but it is ugly when all programs have shadows while Firefox doesn't.

@equeim equeim changed the title Incorrect Firefox autoscroll shadow Incorrect Firefox shadow Jun 5, 2014
@equeim
Copy link
Author

equeim commented Jun 5, 2014

It seems that i found the workaround: include "class_g = 'Firefox' && !window_type *= 'menu'" in your shadow-exclude condition. However I don't think that it is the real solution: other compositors, like compiz or mutter draw firefox shadows correctly without additional configuration.

@equeim
Copy link
Author

equeim commented Jun 5, 2014

Also this isn't ideal solution. Ugly shadow from site details disappeared, but not from bookmarks menu.
http://itmages.ru/image/view/1703840/9f23213b
http://itmages.ru/image/view/1703843/718742ed

@richardgv
Copy link
Collaborator

  1. As I've explained for numerous times... I suppose it would be impractical to draw the correct shadow on irregular shaped ARGB windows because its shape may change on every frame, getting the contour on CPU would be all too costly, and I don't know a way to do it properly on GPU.
  2. You could disable -z (clear-shadow) to get nicer shadow on those windows. Note this may have negative effects on other ARGB windows: Your ARGB terminal might be severely darkened, and some ARGB windows in other shapes might show up with a huge shadow.
  3. Another solution is to use some better rules, like --shadow-exclude "class_g = 'Firefox' && argb".

@equeim
Copy link
Author

equeim commented Jun 6, 2014

Another solution is to use some better rules, like --shadow-exclude "class_g = 'Firefox' && argb".

Thanks, it solved the problem.
Nevertheless, how it solved in other compositors? I doubt that they use custom rules for firefox.

@richardgv
Copy link
Collaborator

Nevertheless, how it solved in other compositors? I doubt that they use custom rules for firefox.

compiz-0.8.8 doesn't draw shadows on any ARGB windows by default (search for DECOR_DISPLAY_OPTION_SHADOW_MATCH in its plugins/decoration.c, at line 1230), but its window decorator may draw shadow unconditionally. In effect, it's similar with --shadow-exclude 'argb && (override_redirect || wmwin)' in compton.

cairo-compmgr does no special treatment on ARGB windows.

@marioortizmanero
Copy link

Quick update: if you're going to use "class_g = 'Firefox' && !window_type *= 'menu'", please note that it may be lowercase firefox instead. They might have changed the class name.

tryone144 pushed a commit to tryone144/compton that referenced this issue Dec 20, 2019
@cubetastic33
Copy link

How do I disable shadows for Firefox Nightly? "class_g = 'Firefox' && !window_type *= 'menu'" doesn't seem to be working, and I don't know how to figure out the class name

@Kr1ss-XD
Copy link

Kr1ss-XD commented Mar 15, 2020

I don't know how to figure out the class name

@cubetastic33 - You can use the xprop tool in order to do so. After launching click into the window in question, and you'll get the window properties as output.

One of these is an array called something like _WM_WINDOW_CLASS or _WM_CLASS (with or without the leading underscore) consisting of two string values, the later of which is the window "class". (The former one is the "instance", btw.)

E/ A simple xprop WM_CLASS followed by a click into the window should give you only the output you need.

@cubetastic33
Copy link

Ah, thanks!

@Kzinux
Copy link

Kzinux commented May 13, 2020

class_g = 'Firefox' && !window_type *= 'menu' also disable the shadow of firefox main window.
Change it to "class_g = 'firefox' && window_type = 'utility'" will only exclude tooltip menu.

jameslikeslinux added a commit to jameslikeslinux/dotfiles that referenced this issue Jun 16, 2020
@OJFord
Copy link

OJFord commented Oct 28, 2020

The default system-wide configuration includes some shadow-excludes, maybe one of these for Firefox should be in there too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants