Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow-radius 0 does not make shadows solid #357

Open
ghost opened this issue Mar 28, 2016 · 0 comments
Open

shadow-radius 0 does not make shadows solid #357

ghost opened this issue Mar 28, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Mar 28, 2016

(Never submitted an issue before, so apologies if I've done something wrong)

I'd like to set shadows to be perfectly solid at the edges. However, trying to achieve this effect with shadow-radius 0 leaves a small amount of blur still. On the left is what shadow-radius 0 results in, and on the right is the effect I'm desiring. Is there a way to achieve what I'm looking for, or is this missing in compton?
shadow radius

tryone144 pushed a commit to tryone144/compton that referenced this issue Mar 31, 2020
Previously, root ConfigureNotify is handled immediately, by resetting
the backend, which in turn releases all the window images. This puts all
the windows into a state where they don't have images attached, which
they really should be in when the screen is redirected.

(To expand a little, a window without images should only exist if:
    * It's an unmanaged window.
    * Screen is unredirected.)

Normally, this kind of window could be fine, as the next render phase
will re-acquire images for them. However, if a window in this state is
destroyed with fading enabled, then the render phase won't try to
acquire images for it, causing it to go into the main rendering function
without images attached, and trigger an assertion.

This commit delays the handling of root ConfigureNotify until the render
phase. This way, the images will be immediately re-acquired after they
are released, thus prevent this problem from happening.

Also adds a testcase for this.

Fixes chjj#357

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants