Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome space bar problem #48

Closed
KiPSOFT-zz opened this issue Oct 6, 2014 · 4 comments · Fixed by #89
Closed

chrome space bar problem #48

KiPSOFT-zz opened this issue Oct 6, 2014 · 4 comments · Fixed by #89

Comments

@KiPSOFT-zz
Copy link

hi;

i'm using chrome 37.0.2062.124 and i have a space key problem. library not catch space key and not triggered data event. i'm testing on firefox 32 nothing problem.

thanks.

@KiPSOFT-zz
Copy link
Author

i'm add this line on Terminal.prototype.keyDown.

case 32:
      key = '\x20';
      break;

solved my problem.

@IonicaBizau
Copy link
Contributor

@KiPSOFT Oh, man, thanks! 🍰

@IonicaBizau
Copy link
Contributor

@KiPSOFT I created a PR with that change: #89

@KiPSOFT-zz
Copy link
Author

Great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants