Handle space bar key down #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Smooth Scrolling extension for Chrome for some reason the space bar is not working. This fixes it adding support for space bar key down.
This was referenced Sep 15, 2015
Closed
Merged
|
@chjj Can you please take a look at this? 🙏 |
|
@chjj 🔔 |
|
Strange. I guess it sends it on keydown instead of keypress in that situation? |
|
@chjj Had no idea what I did, but it fixed my problem. 😄 Basically I just took @KiPSOFT's comment (#48 (comment)) and made a PR. 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Smooth Scrolling extension for Chrome for some reason the space bar is not working. This fixes it adding support for space bar key down.
This fixes #48. Actually I just copy-pasted the code @KiPSOFT posted here. ✨