Add options to disable event binding and focus. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- options.noEvents -- disable global events (keys, etc) - options.noFocus -- disable focus from click - options.noMouse -- disable mouse events
| // Initialize global actions that | ||
| // need to be taken on the document. | ||
| this.initGlobal(); | ||
| if (this.options.noEvents) { |
There was a problem hiding this comment.
Shouldn't this be negative - if (!this.options.noEvents)?
Also, maybe the options should be positively named, so you specify something like events=false instead of noEvents=true.
There was a problem hiding this comment.
Yes, this must've slipped by -- and good point regarding the positive naming, Il'l make these changes.
- options.useEvents -- if false, disable global events (keys, etc) - options.useFocus -- if false, disable focus from click - options.useMouse -- if false, disable mouse events
|
Updated per @takluyver's comments. |
chjj
added a commit
that referenced
this pull request
Apr 23, 2015
Add options to disable event binding and focus.
|
Thanks. I'll revise style a bit, but this is probably a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used these additional options to allow for a ttyrec viewer, which (for usability) requires an inert terminal: http://sufianrhazi.github.io/viewtty.js/