Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Method Documentation from Wiki to Code #1052

Closed
juwens opened this issue Dec 28, 2020 · 4 comments · Fixed by #1055
Closed

Move Method Documentation from Wiki to Code #1052

juwens opened this issue Dec 28, 2020 · 4 comments · Fixed by #1055
Assignees
Labels
feature-request New feature or request

Comments

@juwens
Copy link

juwens commented Dec 28, 2020

Describe the feature request

There is this Wiki page Server and client method documentation

Please move that documentation to the matching Methods in the source code.
The benefits:

  • the developer can see the comments immediately in Visual Studio intellisense.
  • the current way is cumbersome
    • write code in Visual studio
    • lookup method in wiki
  • separate Method documentation is prone of diverging (naming or contentual) from the code.

Which project is your feature request related to?

  • Client
  • ManagedClient
  • MQTTnet.Server standalone
  • Server
  • Generic

Describe the solution you'd like

Move all of the Method documentation in Server and client method documentation directly to the methods in the code.

@juwens juwens added the feature-request New feature or request label Dec 28, 2020
@chkr1011
Copy link
Collaborator

chkr1011 commented Jan 2, 2021

@SeppPenner Do you want to do this?

@SeppPenner SeppPenner self-assigned this Jan 2, 2021
@SeppPenner
Copy link
Collaborator

Which classes should I document? All the public available methods and properties for the client and server side (and the extensions)?

@chkr1011
Copy link
Collaborator

chkr1011 commented Jan 2, 2021

In my opinion the most important parts are all builders and the factory. They should be used to compose most things.
And another interesting this are the interfaces of the clients and server (including the extension methods).
All other things like API which are available but not "visible" to the user (like SessionManager in the server).

And one last thing: We should avoid useless comments. So writing "Gets or sets the host" for the "Host" property has no benefit and can be avoided. Such things do not need any comments (in my opinion). Only some interesting side information like the default port at the Port property has benefits.

@SeppPenner
Copy link
Collaborator

Ok, I start with the client and add some comments and we can discuss if something is not needed or else here. I will let you know when I have the first things done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants