Skip to content

Commit

Permalink
s3: consistent resolver function name
Browse files Browse the repository at this point in the history
Signed-off-by: Carl Henrik Lunde <chlunde@ifi.uio.no>
  • Loading branch information
chlunde committed Jul 8, 2021
1 parent fb94472 commit 7ebcfd7
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions apis/s3/v1beta1/referencers.go
Expand Up @@ -51,17 +51,6 @@ func BucketARN() reference.ExtractValueFn {
}
}

// BucketARN2 Why not like this? :shrug:
func BucketARN2(mg resource.Managed) string {
r, ok := mg.(*Bucket)
if !ok {
return ""
}
return r.Status.AtProvider.ARN
}

var _ reference.ExtractValueFn = BucketARN2

// ResolveReferences of this Bucket
func (mg *Bucket) ResolveReferences(ctx context.Context, c client.Reader) error { // nolint:gocyclo
r := reference.NewAPIResolver(c, mg)
Expand Down Expand Up @@ -125,7 +114,7 @@ func (mg *Bucket) ResolveReferences(ctx context.Context, c client.Reader) error
Reference: v.Destination.BucketRef,
Selector: v.Destination.BucketSelector,
To: reference.To{Managed: &Bucket{}, List: &BucketList{}},
Extract: BucketARN2,
Extract: BucketARN(),
})
if err != nil {
return errors.Wrapf(err, "spec.forProvider.replicationConfiguration.rules[%d].bucket", i)
Expand Down

0 comments on commit 7ebcfd7

Please sign in to comment.