Remove legacy tests. Add test_units to github workflow. Closes #69

chmarti1 · Oct 26, 2022 · 0dc73a5 · 0dc73a5
1 parent d7ca5db
commit 0dc73a5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 48 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -27,4 +27,7 @@ jobs:
       run: pytest test_ig.py
     - name: Test Multiphase
       working-directory: ./src/test
-      run: pytest test_mp1.py
+      run: pytest test_mp1.py
+    - name: Test Unit Conversion
+      working-directory: ./src/test
+      run: pytest test_units.py
diff --git a/src/test/test_ig.py b/src/test/test_ig.py
@@ -454,19 +454,6 @@ def test_he(self, param, refdat):
         with raises(pm.utility.PMParamError):
             fn(h=ref['h'], e=ref['e'])
 
-    # Legacy (deprecated) functions
-    def test_T_s(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.T_s(s=ref['s'], p=ref['p']) == approx(ref['T'], rel=1e-5, abs=1e-1)
-
-    def test_T_h(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.T_h(h=ref['h']) == approx(ref['T'], rel=1e-5, abs=1e-1)
-
-    def test_p_s(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.p_s(s=ref['s'], T=ref['T']) == approx(ref['p'], rel=1e-5, abs=1e-1)
-
 
 class TestState:
 

diff --git a/src/test/test_mp1.py b/src/test/test_mp1.py
@@ -741,40 +741,6 @@ def test_vx(self, param, refdat):
             with raises(pm.utility.PMParamError):
                 fn(d=ref['d'], x=ref['x'])
 
-    # Legacy deprecated items
-    def test_hsd(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        h, s, d = sub.hsd(T=ref['T'], p=ref['p'], x=ref['x'])
-        assert h == approx(ref['h'], rel=1e-5, abs=1e-2)
-        assert s == approx(ref['s'], rel=1e-5, abs=1e-2)
-        assert d == approx(ref['d'], rel=1e-5, abs=1e-2)
-        h, s, d, x = sub.hsd(T=ref['T'], p=ref['p'], x=ref['x'], quality=True)
-        assert h == approx(ref['h'], rel=1e-5, abs=1e-2)
-        assert s == approx(ref['s'], rel=1e-5, abs=1e-2)
-        assert d == approx(ref['d'], rel=1e-5, abs=1e-2)
-        assert x == approx(ref['x'], rel=1e-5, abs=1e-2)
-
-    def test_T_s(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.T_s(s=ref['s'], p=ref['p']) == approx(ref['T'], rel=1e-5, abs=1e-2)
-        T, x = sub.T_s(s=ref['s'], p=ref['p'], quality=True)
-        assert T == approx(ref['T'], rel=1e-5, abs=1e-2)
-        assert x == approx(ref['x'], rel=1e-5, abs=1e-2)
-
-    def test_d_s(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.d_s(s=ref['s'], p=ref['p']) == approx(ref['d'], rel=1e-5, abs=1e-2)
-        d, x = sub.d_s(s=ref['s'], p=ref['p'], quality=True)
-        assert d == approx(ref['d'], rel=1e-5, abs=1e-2)
-        assert x == approx(ref['x'], rel=1e-5, abs=1e-2)
-
-    def test_T_h(self, refdat):
-        sub, ref = refdat['sub'], refdat['data']
-        assert sub.T_h(h=ref['h'], p=ref['p']) == approx(ref['T'], rel=1e-5, abs=1e-2)
-        T, x = sub.T_h(h=ref['h'], p=ref['p'], quality=True)
-        assert T == approx(ref['T'], rel=1e-5, abs=1e-2)
-        assert x == approx(ref['x'], rel=1e-5, abs=1e-2)
-
 
 class TestState: