Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse routines do not convert units #64

Closed
chmarti1 opened this issue Oct 12, 2022 · 1 comment
Closed

Inverse routines do not convert units #64

chmarti1 opened this issue Oct 12, 2022 · 1 comment

Comments

@chmarti1
Copy link
Owner

In version 2.2.2, the inverse routines like T_h, T_s, and p_s do not convert the units of the results. They always return their results in the native units of the model. For temperature, that is always Kelvin, but for pressure it could be bar or Pa. This is a bug and not the documented behavior.

The Problem
As of version 2.2.0, the inverse methods are simply wrapper functions around the new argument parsing system. They are deprecated in favor of calling property methods directly (e.g. T(s=s, p=p) instead of T_s(s=s, p=p)). We've had a couple of bumps (see issue #52) caused by implementing these wrappers without sufficient caution for the number of ways they can break.

The Fix
There is already a plan to release version 2.2.3, in which this issue will be addressed, but users can address the issue right away by transitioning to the new property interface in favor of the old inverse routines. The new argument parsing system will accept combinations of entropy, enthalpy, density, specific volume, temperature, pressure, and quality.

@chmarti1
Copy link
Owner Author

This issue is now addressed in version 2.2.4. The call signatures have also reverted to be identical to their appearances in version 2.1.10 to prevent any more issues like issue #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant