-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
air.T_s claims temperature out-of-bounds when using reverse values from air.s #52
Comments
So the problem there has to do with the way PyroMat interprets arguments that aren't explicitly specified. As of ver 2.2, the first positional argument is always assumed to be T and the second p. Since T_s is a legacy function, it does retain the first argument as s, but then the next one is immediately interpreted as T. So what's really being done in your function call is: I'll let @chmarti1 speak up as to how he wants to deal with the function headers on stuff like this, but you could fix this in your code right away by specifying explicitly Of note as well is that since 2.2, the calls like T_s aren't necessary anymore, because the underlying argument parser handles all possible arg pairs. So calling |
@jranalli is right - this is a small departure from the legacy In a related note, I just noticed a typo in the documentation that calls these function "Depreciated" instead of "Deprecated" (oops). The point is the same. We'll keep the |
I've looked at your code. It looks like line 117 is the only one that needs a fix to quickly avoid the issue. I recommend just changing it to read t3_is = float(air.T(s=s1, p=p3)) That will work with version 2.2.1. If you want, you can also abandon Thanks for calling this to our attention! |
Thanks! That worked. |
…gnatures for deprecated T_s, etc. function calls.
Modifications in response to issue #52 to go back to original call si…
should result in 250, but raises the following error:
PMParamError: All of the specified states were out-of-bounds. Legal temperatures for ig.air are between 200.0 and 6000.0 Kelvin.
The text was updated successfully, but these errors were encountered: