Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code breaks on d_s() #69

Closed
chmarti1 opened this issue Oct 26, 2022 · 0 comments · Fixed by #70
Closed

Test code breaks on d_s() #69

chmarti1 opened this issue Oct 26, 2022 · 0 comments · Fixed by #70

Comments

@chmarti1
Copy link
Owner

chmarti1 commented Oct 26, 2022

The test code breaks on mp1.d_s() now that I have reverted back to version 2.1.10 call signatures. It tries to pass pressure as an argument, but that was not originally supported. I'd recommend that we simply stop testing these deprecated functions. Unless there are community-raised issues with them, we shouldn't need to touch them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant