fix: handling document click after manual update #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 25, 2021 11:25
When manual input is allowed, the user input was not respected, when a user clicks anywhere in the document body instead of pressing TAB key. This results in 'click'->'blur' event sequence as opposed to only a blur event. This results in setting the date always from the calendar element. The fix compares the date from the input with the latest selected date; if it matches then the changes is coming from the calendar control and updates the date time from calendar control, as before. Otherwise the change is coming from the input control, and it simply overwrites the latest selected date. The synchronization step later takes care of the rest, as before.
This is similar to ENTER handling behvior on the time inputs.
|
@chmln I have the same issue. Does this fix need any adjustments? |
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Mar 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [flatpickr](https://flatpickr.js.org) ([source](https://togithub.com/chmln/flatpickr)) | [`4.6.9` -> `4.6.10`](https://renovatebot.com/diffs/npm/flatpickr/4.6.9/4.6.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>chmln/flatpickr</summary> ### [`v4.6.10`](https://togithub.com/chmln/flatpickr/releases/v4.6.10) [Compare Source](https://togithub.com/chmln/flatpickr/compare/v4.6.9...v4.6.10) ##### What's Changed - Support Z & GMT custom parsing by [@​bcfox](https://togithub.com/bcfox) in [flatpickr/flatpickr#2369 - 🌐 \[ar] Translate missing phrases. by [@​mohamedsabil83](https://togithub.com/mohamedsabil83) in [flatpickr/flatpickr#2370 - fix: restrict onKeyDown listener to Flatpickr only fixes [#​1444](https://togithub.com/chmln/flatpickr/issues/1444), [#​1387](https://togithub.com/chmln/flatpickr/issues/1387) by [@​ghiscoding](https://togithub.com/ghiscoding) in [flatpickr/flatpickr#2329 - 🌐\[ko] Add missing am/pm translation by [@​darron1217](https://togithub.com/darron1217) in [flatpickr/flatpickr#2379 - Add missing horizontal position strings to position option type by [@​danielpierre](https://togithub.com/danielpierre) in [flatpickr/flatpickr#2400 - Support reversed ranges for minTime and maxTime by [@​MiroslavCsonka](https://togithub.com/MiroslavCsonka) in [flatpickr/flatpickr#2482 - Fix incorrectly migrated package-lock.json by [@​andersk](https://togithub.com/andersk) in [flatpickr/flatpickr#2467 - Compile all ES6+ syntax to ES5 by [@​andersk](https://togithub.com/andersk) in [flatpickr/flatpickr#2469 - \[fix] apply positionElement to instance.\_positionElement when fp.set by [@​fifzteen](https://togithub.com/fifzteen) in [flatpickr/flatpickr#2466 - Fix rangePlugin selection problems by [@​SquareBeard](https://togithub.com/SquareBeard) in [flatpickr/flatpickr#1795 - Fix maxTime bound bug by [@​MiroslavCsonka](https://togithub.com/MiroslavCsonka) in [flatpickr/flatpickr#2483 - Fix parseDate on relative inputs by [@​juliapath](https://togithub.com/juliapath) in [flatpickr/flatpickr#2475 - Add range separator for Swedish locale by [@​mlonn](https://togithub.com/mlonn) in [flatpickr/flatpickr#2434 - Update sv.ts by [@​davemccrea](https://togithub.com/davemccrea) in [flatpickr/flatpickr#2449 - feat: add norwegian nynorsk by [@​tw15egan](https://togithub.com/tw15egan) in [flatpickr/flatpickr#2423 - Update fi.ts by [@​davemccrea](https://togithub.com/davemccrea) in [flatpickr/flatpickr#2450 - Eliminate memory leak caused by event listener accumulation by [@​jefrailey](https://togithub.com/jefrailey) in [flatpickr/flatpickr#2596 - Adjusts month abbreviation and adds aria-labels for the Greek translation (i10n) by [@​delight](https://togithub.com/delight) in [flatpickr/flatpickr#2555 - Keyboard doesn't work inside Shadow Dom by [@​mwoess](https://togithub.com/mwoess) in [flatpickr/flatpickr#2519 - Check exsitance of years and month in scrollPlugin by [@​mojtaba-khallash](https://togithub.com/mojtaba-khallash) in [flatpickr/flatpickr#2571 - Create ar-dz.ts locales by [@​anugrahsoft](https://togithub.com/anugrahsoft) in [flatpickr/flatpickr#2556 - fix: `onClose` callback was returning wrong selected dates if user changed input before close. by [@​DimitrisRK](https://togithub.com/DimitrisRK) in [flatpickr/flatpickr#2541 - Remove repeating 'onChange' trigger by [@​quis0](https://togithub.com/quis0) in [flatpickr/flatpickr#2506 - Append to container and children no longer classed as calendar elements by [@​cmubo](https://togithub.com/cmubo) in [flatpickr/flatpickr#2500 - Updated week day for Sunday in ms.ts by [@​izwanakhirruddin](https://togithub.com/izwanakhirruddin) in [flatpickr/flatpickr#2496 - Add range separator to Catalan by [@​toniavanza](https://togithub.com/toniavanza) in [flatpickr/flatpickr#2495 - Fix for calendar position on Safari by [@​octaviofernands](https://togithub.com/octaviofernands) in [flatpickr/flatpickr#2391 - chore: replace CircleCI status badge with GitHub Actions status by [@​ghiscoding](https://togithub.com/ghiscoding) in [flatpickr/flatpickr#2384 - monthSelect plugin: Support "range" mode by [@​rlue](https://togithub.com/rlue) in [flatpickr/flatpickr#2297 - fix: GitHub Actions badge fix invalid url typo by [@​ghiscoding](https://togithub.com/ghiscoding) in [flatpickr/flatpickr#2597 - add Armenian locale by [@​vakopian](https://togithub.com/vakopian) in [flatpickr/flatpickr#2604 - Fixes confirmDate focus accessibility by [@​gustavoaz7](https://togithub.com/gustavoaz7) in [flatpickr/flatpickr#2633 - Add 'time\_24hr: true' to Austrian locale by [@​berndy2001](https://togithub.com/berndy2001) in [flatpickr/flatpickr#2612 - Prevent text selection on prev/next month buttons by [@​metonym](https://togithub.com/metonym) in [flatpickr/flatpickr#2603 - Fix issues with parsing localized date/time by [@​mshibuya](https://togithub.com/mshibuya) in [flatpickr/flatpickr#2600 - add kurdish (sorani) language by [@​swara-mohammed](https://togithub.com/swara-mohammed) in [flatpickr/flatpickr#2620 - Fix [#​2541](https://togithub.com/chmln/flatpickr/issues/2541) breaking with altInput enabled by [@​mshibuya](https://togithub.com/mshibuya) in [flatpickr/flatpickr#2601 - fix: handling document click after manual update by [@​Sayan751](https://togithub.com/Sayan751) in [flatpickr/flatpickr#2419 ##### New Contributors - [@​bcfox](https://togithub.com/bcfox) made their first contribution in [flatpickr/flatpickr#2369 - [@​mohamedsabil83](https://togithub.com/mohamedsabil83) made their first contribution in [flatpickr/flatpickr#2370 - [@​darron1217](https://togithub.com/darron1217) made their first contribution in [flatpickr/flatpickr#2379 - [@​danielpierre](https://togithub.com/danielpierre) made their first contribution in [flatpickr/flatpickr#2400 - [@​MiroslavCsonka](https://togithub.com/MiroslavCsonka) made their first contribution in [flatpickr/flatpickr#2482 - [@​andersk](https://togithub.com/andersk) made their first contribution in [flatpickr/flatpickr#2467 - [@​fifzteen](https://togithub.com/fifzteen) made their first contribution in [flatpickr/flatpickr#2466 - [@​juliapath](https://togithub.com/juliapath) made their first contribution in [flatpickr/flatpickr#2475 - [@​mlonn](https://togithub.com/mlonn) made their first contribution in [flatpickr/flatpickr#2434 - [@​davemccrea](https://togithub.com/davemccrea) made their first contribution in [flatpickr/flatpickr#2449 - [@​tw15egan](https://togithub.com/tw15egan) made their first contribution in [flatpickr/flatpickr#2423 - [@​jefrailey](https://togithub.com/jefrailey) made their first contribution in [flatpickr/flatpickr#2596 - [@​delight](https://togithub.com/delight) made their first contribution in [flatpickr/flatpickr#2555 - [@​mwoess](https://togithub.com/mwoess) made their first contribution in [flatpickr/flatpickr#2519 - [@​mojtaba-khallash](https://togithub.com/mojtaba-khallash) made their first contribution in [flatpickr/flatpickr#2571 - [@​anugrahsoft](https://togithub.com/anugrahsoft) made their first contribution in [flatpickr/flatpickr#2556 - [@​DimitrisRK](https://togithub.com/DimitrisRK) made their first contribution in [flatpickr/flatpickr#2541 - [@​quis0](https://togithub.com/quis0) made their first contribution in [flatpickr/flatpickr#2506 - [@​cmubo](https://togithub.com/cmubo) made their first contribution in [flatpickr/flatpickr#2500 - [@​izwanakhirruddin](https://togithub.com/izwanakhirruddin) made their first contribution in [flatpickr/flatpickr#2496 - [@​toniavanza](https://togithub.com/toniavanza) made their first contribution in [flatpickr/flatpickr#2495 - [@​octaviofernands](https://togithub.com/octaviofernands) made their first contribution in [flatpickr/flatpickr#2391 - [@​vakopian](https://togithub.com/vakopian) made their first contribution in [flatpickr/flatpickr#2604 - [@​gustavoaz7](https://togithub.com/gustavoaz7) made their first contribution in [flatpickr/flatpickr#2633 - [@​berndy2001](https://togithub.com/berndy2001) made their first contribution in [flatpickr/flatpickr#2612 - [@​metonym](https://togithub.com/metonym) made their first contribution in [flatpickr/flatpickr#2603 - [@​mshibuya](https://togithub.com/mshibuya) made their first contribution in [flatpickr/flatpickr#2600 - [@​swara-mohammed](https://togithub.com/swara-mohammed) made their first contribution in [flatpickr/flatpickr#2620 - [@​Sayan751](https://togithub.com/Sayan751) made their first contribution in [flatpickr/flatpickr#2419 **Full Changelog**: flatpickr/flatpickr@v4.6.9...v4.6.10 </details> --- ### Configuration 📅 **Schedule**: "every weekend" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/carbon-design-system/carbon-for-ibm-dotcom).
](https://renovatebot.com){kind=link}
mshibuya
added a commit
to mshibuya/flatpickr
that referenced
this pull request
Mar 12, 2022
chmln
added a commit
that referenced
this pull request
Mar 12, 2022
Fix #2419 breaking with altInput and altFormat Enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily it fixes #2394
The cause of the issue
When manual input is allowed, the user input was not respected, when a user clicks anywhere in the document body instead of pressing TAB key. This results in 'click'->'blur' event sequence as opposed to only a blur event. This results in setting the date always from the calendar element.
The fix
The fix compares the date from the input with the latest selected date; if it matches then the changes is coming from the calendar control and updates the date time from calendar control, as before. Otherwise the change is coming from the input control, and it simply overwrites the latest selected date. The synchronization step later takes care of the rest, as before.
Additionally, it contains changes to close the calendar popup when ENTER is pressed on the input field. This is similar to the ENTER handling behavior on the time input fields.