Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'uninstall' option to snooze. #1

Closed
wants to merge 1 commit into from
Closed

Added 'uninstall' option to snooze. #1

wants to merge 1 commit into from

Conversation

pranomostro
Copy link

No description provided.

@leahneukirchen
Copy link
Owner

Sorry, I'm not too fond of this idea and this particular implementation.

  • make uninstall is fundamentally a hack, I'd rather recommend you use checkinstall, stow or make a native package if you want to uninstall anything.
  • ALL is possibly a list, so this would need proper iteration at least.
  • It seems cleaner to me to generate a uninstall.sh script during make install, tracking exactly what has been installed where.
  • These packages currently install two files, so adding a proper rule is still more work than manual uninstallation.

This also applies to your other uninstall PR.

@leahneukirchen
Copy link
Owner

leahneukirchen/lr#8

@pranomostro
Copy link
Author

Okay.
Yeah, I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants