Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with curriculum learning? #26

Open
PietroLodiRizzini opened this issue Feb 13, 2024 · 0 comments
Open

Problem with curriculum learning? #26

PietroLodiRizzini opened this issue Feb 13, 2024 · 0 comments

Comments

@PietroLodiRizzini
Copy link

PietroLodiRizzini commented Feb 13, 2024

the decoder of the DCRNNModel in model/pytorch/dcrnn_model.py seems to be fed with its own output when use_curriculum_learning is set to False:

for t in range(self.decoder_model.horizon):
            decoder_output, decoder_hidden_state = self.decoder_model(decoder_input,
                                                                      decoder_hidden_state)
            decoder_input = decoder_output
            outputs.append(decoder_output)
            if self.training and self.use_curriculum_learning:
                c = np.random.uniform(0, 1)
                if c < self._compute_sampling_threshold(batches_seen):
                    decoder_input = labels[t]

However, I think it should be fed with ground truth labels, isn't it?
cfr. DCRNN paper, page 4 1st line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant