Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing results during training #4

Open
razvanc92 opened this issue May 15, 2020 · 7 comments
Open

Testing results during training #4

razvanc92 opened this issue May 15, 2020 · 7 comments

Comments

@razvanc92
Copy link

Hello, firstly I would like to thank you for the implementation. I've been trying to use your implementation and I've noticed a big difference, during training when evaluating (fx every 10 steps) you're only reporting the mae (over all 12 time stamps), while DCRNN reports mae/mape/rmse for every time stamp. I would be interested to see those numbers during training, or at least at the end of the training so I can compare it with other models. Do you have any suggestions how I could do this?

@AprLie
Copy link

AprLie commented May 16, 2020

Hello, firstly I would like to thank you for the implementation. I've been trying to use your implementation and I've noticed a big difference, during training when evaluating (fx every 10 steps) you're only reporting the mae (over all 12 time stamps), while DCRNN reports mae/mape/rmse for every time stamp. I would be interested to see those numbers during training, or at least at the end of the training so I can compare it with other models. Do you have any suggestions how I could do this?

you can rewrite evalute() in dcrnn_supervisor. I could provide the code which outputs this three metrics.
ps: The distance between nodes (the .csv file) should be float dtype, or you will have dtype mismatch problem.

@chnsh
Copy link
Owner

chnsh commented May 16, 2020

@razvanc92 that is a reasonable request - @AprLie thanks for your help. Would @razvanc92 and @AprLie be willing to send in a PR?

@Noahprog
Copy link

I would like to use that too if that is possible, @AprLie @chnsh could you forward that code? I'm not sure how though.
Thanks in advance

@yandou904
Copy link

Hello, firstly I would like to thank you for the implementation. I've been trying to use your implementation and I've noticed a big difference, during training when evaluating (fx every 10 steps) you're only reporting the mae (over all 12 time stamps), while DCRNN reports mae/mape/rmse for every time stamp. I would be interested to see those numbers during training, or at least at the end of the training so I can compare it with other models. Do you have any suggestions how I could do this?

you can rewrite evalute() in dcrnn_supervisor. I could provide the code which outputs this three metrics. ps: The distance between nodes (the .csv file) should be float dtype, or you will have dtype mismatch problem.

I have met with the same problem, could you also provide me with the same code? thank you!

@yandou904
Copy link

I would like to use that too if that is possible, @AprLie @chnsh could you forward that code? I'm not sure how though. Thanks in advance

Have you got the answer? Could you please provide me with one? Thank you!

@Yangzelin99
Copy link

I would like to use that too if that is possible, @AprLie @chnsh could you forward that code? I'm not sure how though. Thanks in advance

Have you got the answer? Could you please provide me with one? Thank you!

I'm running into this issue as well.Have you got the answer? Could you please provide me with one? Thank you!

@User766843
Copy link

I would like to use that too if that is possible, @AprLie @chnsh could you forward that code? I'm not sure how though. Thanks in advance

Have you got the answer? Could you please provide me with one? Thank you!

I'm running into this issue as well.Have you got the answer? Could you please provide me with one? Thank you!

Have you got the answer? Could you please provide me with one? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants