return the same status code 403 as nginx does to refuse CONNECT method #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod If proxy_connect module is not enabled, the server will return a 405 status code instead of 400.
chobits
commented
Feb 7, 2023
| @@ -2342,7 +2342,7 @@ ngx_http_proxy_connect_post_read_handler(ngx_http_request_t *r) | |||
| if (!pclcf->accept_connect) { | |||
| ngx_log_error(NGX_LOG_INFO, r->connection->log, 0, | |||
| "proxy_connect: client sent connect method"); | |||
| return NGX_HTTP_BAD_REQUEST; | |||
| return NGX_HTTP_NOT_ALLOWED; | |||
There was a problem hiding this comment.
refer to nginx core logic:
ngx_http_process_request_header(ngx_http_request_t *r)
{
....
if (r->method == NGX_HTTP_CONNECT) {
ngx_log_error(NGX_LOG_INFO, r->connection->log, 0,
"client sent CONNECT method");
ngx_http_finalize_request(r, NGX_HTTP_NOT_ALLOWED);
return NGX_ERROR;
}
...
}
chobits
commented
Feb 7, 2023
| @@ -57,6 +57,7 @@ jobs: | |||
| pwd | |||
| git clone https://github.com/openresty/lua-resty-core.git | |||
| cd lua-resty-core | |||
| git checkout d2179dbcb3d6d77127462cadd40cca103d89a52a | |||
There was a problem hiding this comment.
try to fix error in github workflow
/opt/nginx/lib/lua/resty/core/base.lua:24: ngx_http_lua_module 0.10.23 required) in /tmp/nginx-test-LEG22dEa9Q/nginx.conf:93
nginx: [alert] failed to load the 'resty.core' module (https://github.com/openresty/lua-resty-core); ensure you are using an OpenResty release from https://openresty.org/en/download.html (reason: /opt/nginx/lib/lua/resty/core/base.lua:24: ngx_http_lua_module 0.10.23 required) in /tmp/nginx-test-LEG22dEa9Q/nginx.conf:93
Can't start nginx at /home/runner/work/ngx_http_proxy_connect_module/ngx_http_proxy_connect_module/nginx/../nginx-tests/lib/Test/Nginx.pm line 350.
chobits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If proxy_connect module is not enabled, the server will return a 405 status code instead of 400.