Merge pull request #1119 from mfrancis95/master

Fix memory leak in Strife related to finding voices.wad and make finding it case-insensitive
chocolate-doom · Dec 12, 2018 · 482d302 · 482d302
2 parents 1b98fb5 + b18f464
commit 482d302
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/strife/d_main.c b/src/strife/d_main.c
@@ -855,10 +855,8 @@ void D_IdentifyVersion(void)
             voiceswad = M_SafeFilePath(iwadpath, "voices.wad");
             Z_Free(iwadpath);
 
-            if(!M_FileExists(voiceswad))
-                Z_Free(voiceswad);
-            else
-                name = voiceswad; // STRIFE-FIXME: memory leak!!
+            name = M_FileCaseExists(voiceswad);
+            Z_Free(voiceswad);
         }
 
         // not found? try global search paths
@@ -877,6 +875,7 @@ void D_IdentifyVersion(void)
         {
             // add it.
             D_AddFile(name);
+            free(name);
         }
     }
 }