Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashed when both a multiplier and "-fullscreen" are given #338

Closed
fabiangreffrath opened this issue Feb 14, 2014 · 2 comments
Closed

Crashed when both a multiplier and "-fullscreen" are given #338

fabiangreffrath opened this issue Feb 14, 2014 · 2 comments

Comments

@fabiangreffrath
Copy link
Member

Hi again,

i think it should be possible to directly tell chocolate-doom on the command line which scaling multiplier it should use in fullscreen mode. However, running "chocolate-doom -n -fullscreen" instantly crashes for n <= 3 on my system. Interestingly, it works for n = 4 and n = 5. My native display resolution is 1600x900.

  • Fabian
@fabiangreffrath
Copy link
Member Author

I believe this happens, because I_GraphicsCheckCommandLine() is called in D_DoomLoop() [d_main.c:445] before I_InitGraphics(). In I_GraphicsCheckCommandLine() [i_video.c:1776] SetScaleFactor(1) is called if (M_CheckParm("-1")). SetScaleFactor(), in turn, calls SDL_ListModes() if (fullscreen) [i_video.c:1559] and so this all happens before I_InitGraphics() has been called to initialize the graphics system.

@fragglet
Copy link
Member

Fixed, thanks. I decided to just ditch the complicated fullscreen scale factor logic.

Azarien pushed a commit to Azarien/chocolate-doom that referenced this issue Apr 11, 2020
@fabiangreffrath
highlight revealed secret sectors in green on the Automap
2254778 
That is, unrevealed secret sectors are drawn normally without the IDDT
cheat and in purple with the IDDT cheat. Revealed secrets are drawn in
green regardless of IDDT.

While at it, save revealed secret sector status in extended savegames,
so this remains intact across save/load cycles.

Fixes chocolate-doom#338, I hope you are happy now @Zodomaniac! 😉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fragglet @fabiangreffrath