Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doom: support common auto-loaded files for all Doom flavors #1183

Merged
merged 2 commits into from Jul 11, 2019

Conversation

fabiangreffrath
Copy link
Member

Fixes: #1182

@fabiangreffrath
Copy link
Member Author

To provide some more context: I have a similar feature in Crispy that I'd currently like to get rid of, but it applies to all IWADs.

@fabiangreffrath
Copy link
Member Author

I'll merge this after the weekend if nobody objects until then.

@fragglet
Copy link
Member

fragglet commented Jul 5, 2019

Seems good. Only question: is "common" a good name? These only get loaded with Doom IWADs, not Heretic/Hexen/Strife - this is correct behavior but the name might suggest they would get loaded with all of them.

I can't think of a better name OTOH so I'm happy going with "common" but maybe you can think of something.

@fabiangreffrath
Copy link
Member Author

We could add "doom" to the directory name and call it something like
doom-common
common-doom
doom-any
any-doom
doom-all
all-doom

or whatever you prefer. 😉

@fragglet
Copy link
Member

Let's go with doom-all then.

@fabiangreffrath fabiangreffrath merged commit f1d557f into master Jul 11, 2019
@fabiangreffrath
Copy link
Member Author

Done so, thanks!

@fabiangreffrath fabiangreffrath deleted the autoloadcommon branch July 11, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common autoload path for all Doom IWADs
2 participants