Add options to disable SDL2_net and SDL2_mixer for increased portability #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was automatically being pulled in by SDL2::net but without that will be missing.
They're needed even when SDL2_mixer is disabled
It's needed even when SDL2_mixer is disabled
It's needed even when SDL2_mixer is disabled
|
The linter definitely seems to complain about lines I didn't change. This is strange because the actual command tells it the right lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to disable SDL2_net and SDL2_mixer for increased portability.
emscripten for example has no conventional networking so SDL2_net does nothing useful there.
Several old/strange platforms have problems with audio and porting to them might benefit from the ability to just disable it at compile time.
This still leaves in most of the support code since removing it would be extremely invasive. Also base SDL2 is required for multiple functions. Removing it might be useful for truly strange platforms, fuzzing or using tools like
rrwhich don't like hardware rendering. It might be useful to add an option for that as well in the future.