configure: fix --with-PACKAGE option checks #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options of the form --with-PACKAGE[=yes] (e.g. --with-libpng), when passed to configure, were being treated as though --without-PACKAGE had been given. Although the intention is to have configure check and use PACKAGE by default if it's available, thus requiring the user to pass an option only if PACKAGE must NOT be used, there are times when the opposite might be desired (i.e. the user wants to indicate PACKAGE MUST be used). Moreover, allowing --with-PACKAGE and behaving as if --without-PACKAGE had been specified is in itself quite confusing. Fix that by testing the result of 'with_PACKAGE' in configure.ac and acting accordingly instead of blindly assuming a 'no'.
fragglet
added a commit
that referenced
this pull request
Oct 26, 2015
configure: fix --with-PACKAGE option checks
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options of the form --with-PACKAGE[=yes] (e.g. --with-libpng), when
passed to configure, were being treated as though --without-PACKAGE had
been given.
Although the intention is to have configure check and use PACKAGE by
default if it's available, thus requiring the user to pass an option
only if PACKAGE must NOT be used, there are times when the opposite
might be desired (i.e. the user wants to indicate PACKAGE MUST be used).
Moreover, allowing --with-PACKAGE and behaving as if --without-PACKAGE
had been specified is in itself quite confusing.
Fix that by testing the result of 'with_PACKAGE' in configure.ac and
acting accordingly instead of blindly assuming a 'no'.