Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version.pm must be used to support version tuples on perl 5.8 #11

Closed
Grinnz opened this issue May 5, 2018 · 3 comments
Closed

version.pm must be used to support version tuples on perl 5.8 #11

Grinnz opened this issue May 5, 2018 · 3 comments

Comments

@Grinnz
Copy link

Grinnz commented May 5, 2018

version.pm is not used for core version comparisons until 5.10 or if it's loaded. So to support 5.8, version tuples should be declared like (on a single line):

use version 0.77; our $VERSION = version->declare('v3.0.0');

and version should be added to your module's runtime dependencies. See http://blogs.perl.org/users/grinnz/2018/04/a-guide-to-versions-in-perl.html under Declaring Versions, and https://metacpan.org/pod/version#How-to-declare()-a-dotted-decimal-version.

@chocolateboy
Copy link
Owner

Thanks. What do I need to change in autobox?

@Grinnz
Copy link
Author

Grinnz commented May 5, 2018

Just the version declaration in autobox.pm as
above (corrected in an edit) (https://github.com/chocolateboy/autobox/blob/master/lib/autobox.pm#L14) and to add version (at least '0.77') to PREREQ_PM in your Makefile.PL.

@chocolateboy
Copy link
Owner

Thanks! Applied in v3.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants