Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/68 #72

Merged
merged 9 commits into from
Apr 5, 2023
Merged

Fix/68 #72

merged 9 commits into from
Apr 5, 2023

Conversation

gaelcolas
Copy link
Member

Changed a bit the logic to validated the $Env:ChocolateyInstall as per #68.

@gaelcolas
Copy link
Member Author

@Jaykul what about these changes?

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d8ffc93) 0.00% compared to head (7bfdeec) 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #72   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines         70      70           
=====================================
  Misses        70      70           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jaykul
Copy link
Contributor

Jaykul commented Apr 2, 2023

I think you still want to change:

$CachePath = [io.path]::Combine($Env:ChocolateyInstall, 'cache', 'GetChocolateyPackageCache.xml')

... to read from MACHINE scope explicitly, because you can't be sure it's set in process scope (you don't explicitly set it there, if it's already set in machine scope, and neither does the chocolatey installer).

@gaelcolas gaelcolas merged commit 140e12f into main Apr 5, 2023
@gaelcolas gaelcolas deleted the fix/68 branch April 5, 2023 21:14
@gaelcolas gaelcolas restored the fix/68 branch April 6, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants