-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/68 #72
Conversation
@(gcm choco)[0]
@Jaykul what about these changes? |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 70 70
=====================================
Misses 70 70 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I think you still want to change:
... to read from MACHINE scope explicitly, because you can't be sure it's set in process scope (you don't explicitly set it there, if it's already set in machine scope, and neither does the chocolatey installer). |
Changed a bit the logic to validated the $Env:ChocolateyInstall as per #68.