Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in tonigellida's packages #32

Closed
ferventcoder opened this issue Dec 4, 2014 · 13 comments
Closed

Bring in tonigellida's packages #32

ferventcoder opened this issue Dec 4, 2014 · 13 comments

Comments

@ferventcoder
Copy link
Contributor

https://github.com/adgellida/chocolateyautomaticpackages

@TomOne
Copy link
Contributor

TomOne commented Dec 4, 2014

I thought you were against the idea of the core team repo as place for pulling in all packages when its former maintainer asks to.

I can remember that you once wrote something like this to Redsandro when he wanted to pull in some of his packages that he didn’t want to maintain anymore.

We should discuss this before taking further steps: #31

@gep13
Copy link
Member

gep13 commented Dec 4, 2014

I can remember that you once wrote something like this to Redsandro when he wanted to pull in some of his packages that he didn’t want to maintain anymore.

I remember that conversation as well, but I think we are now all on the same wave length in terms of bringing packages into this repository. Obivously there are a lot of packages to work on here, and this isn't going to happen overnight, but I think it is something that we can start to do incrementally.

@ferventcoder
Copy link
Contributor Author

I thought you were against the idea of the core team repo as place for pulling in all packages when its former maintainer asks to.

The original idea for this repository was different in my mind than what Gary had for it. It was more about thinking of packages that would have an SLA. I think there may still be a place for that as well, just not here.

I do believe we should be careful about pulling in packages when folks want to stop maintaining them, but I think it's also about the ability for anyone to come along and put in fixes easily for packages on a team repo versus each of our individual threads. Plus many of the packages here are automatic (if not all of them) so that helps.

@gep13
Copy link
Member

gep13 commented Dec 5, 2014

It was more about thinking of packages that would have an SLA. I think there may still be a place for that as well, just not here.

This is an interesting one, and I guess it refers to what side of the SLA you are talking about. If you are talking about a SLA for when a new Chocolatey Package is released when an application version is released, then I think we have that covered. Ketarin runs at the minute every hour, which I guess could be increased, but I think this is more than enough.

If on the other hand you are talking about an SLA for fixing a problem with a package, which I think you are, then this repository would not be the place for that. There are simply too many packages in this repository (and there will likely be more) to say that we are going to be able to fix all issues within a set period of time. This is not what this repository is for. I can see certain high profile packages living in another, similar, repo for that purpose.

@ferventcoder
Copy link
Contributor Author

If on the other hand you are talking about an SLA for fixing a problem with a package, which I think you are, then this repository would not be the place for that. There are simply too many packages in this repository (and there will likely be more) to say that we are going to be able to fix all issues within a set period of time. This is not what this repository is for. I can see certain high profile packages living in another, similar, repo for that purpose.

Right, but that's what the original intention of this repository was from my perspective and why I didn't want it to have a bunch of packages. But there was interest in having it be this way so I relented with the thought that I could just make another repository later. Repos are cheap. :)

@gep13
Copy link
Member

gep13 commented Dec 5, 2014

Repos are cheap. :)

Yip!

@Redsandro
Copy link
Contributor

@adgellida is not so restrictive. When my early packages got refused, he welcomed them and helped converting them to automatic packages.

A lot of his packages are #notSilent and/or #trialVersion. In my opinion, the core team repo should remain free of trial software, and only contain silent installations. So someone would have to sit and figure out how to AutoIt or AutoHotkey them.

It's probably easiest to ask @adgellida if he wants to help 'porting' some of the more popular non-trial packages to core.

@adgellida
Copy link

Right now I can't help choco community, so you have my unmaintained repo to do all that you consider convenient:

  • convert notSilent to silent with AutoHotKey.

  • naming another package maintainer to update them.

  • pull to core.

  • other things...

    If I can return to help you I'll advice you and lend a hand on that you need.
    Thanks for all and best wishes to the team!

@Redsandro
Copy link
Contributor

@ferventcoder we can start by circumventing having to click and add a maintainer 203 times, and accepting to be maintainer 203 times, by entering the chocolatey maintainer directly into the database.

I don't know what database we use and how the maintainers are stored, but here is some pseudo-code that we can use:

$push: { 'maintainer' : $each: 'chocolatey'}
$where: { 'packageId' : { $in: ['0a', '360t', 'acestrea', 'ac', 'ad-awarefreeantiviru', 'adblockpluschrom', 'adblockplusfirefo', 'adblockplusi', 'adblockplusopera', 'adblockplussafari', 'adobeshockwaveplayer', 'advancedsystemcarefree', 'advancedsystemtweaker', 'adwcleaner', 'aida64-business', 'aida64-engineer', 'aida64-extreme', 'aida64-networkaudit', 'allmyapps', 'andy', 'arduinoide', 'arduinoidegalileo', 'ares', 'aria2', 'atraci', 'atubecatcher', 'avastbrowsercleanup', 'avastfreeantivirus', 'avgantivirusfree', 'avginternetsecurity', 'avgpctuneup', 'avirafreeantivirus', 'aviraiss', 'bitdefenderavfree', 'bleachbit', 'bluej-bundled', 'bluej', 'cccp', 'ccenhancer', 'ccleaner', 'cdex', 'chocopkgup', 'clamwin', 'clover', 'colorconsole', 'combofix', 'cpu-z', 'cryenginesdk', 'crystaldiskinfo', 'crystaldiskmark', 'cuevanastorm', 'daemontoolslite', 'ddu', 'designsparkpcb', 'desura', 'disk2vhd', 'downloadapp', 'driverbooster', 'drivergenius', 'dumeter', 'dumo', 'eagle', 'easybcd', 'emule', 'f-secureav', 'f-secureis', 'fbvlc', 'firefox-dev', 'flare', 'fritzing', 'gamebooster', 'gamedownloader', 'geany', 'genymotion', 'githubforwindows', 'goodsync', 'hdtune', 'heroesofnewerth', 'hotswap', 'hpusbdisk', 'icons', 'insync', 'ireboot', 'isoplex', 'jdownloader', 'jrt', 'k-litecodecpackbasic', 'k-litecodecpackfull', 'k-litecodecpackmega', 'k-litecodecpackstandard', 'kav', 'kcleaner', 'kicad', 'kis', 'kss', 'kvrt', 'light', 'line', 'littleregistrycleaner', 'llftool', 'malwarebytes', 'meld', 'messengerreviver', 'midori-browser', 'minetest', 'mipony', 'mousecontroller', 'mozbackup', 'mro-launcher', 'mro', 'mucommander', 'mxnitro', 'officetabenterprise', 'officetabfree', 'onedrive', 'opswatsecurityscore', 'orwelldevcpp', 'oscillation', 'otterbrowser', 'partitionwizard', 'peazip', 'piratebrowser', 'pokerth', 'popcorntime', 'qt-creator-x64', 'qt-creator-x86', 'qt-sdk-android-x86', 'qt-sdk-windows-x64-mingw_opengl_seh', 'qt-sdk-windows-x64-mingw_opengl_sjlj', 'qt-sdk-windows-x64-mingw_seh', 'qt-sdk-windows-x64-mingw_sjlj', 'qt-sdk-windows-x64-msvc2008', 'qt-sdk-windows-x64-msvc2008_opengl', 'qt-sdk-windows-x64-msvc2010', 'qt-sdk-windows-x64-msvc2010_opengl', 'qt-sdk-windows-x64-msvc2012', 'qt-sdk-windows-x64-msvc2012_opengl', 'qt-sdk-windows-x64-msvc2013', 'qt-sdk-windows-x64-msvc2013_opengl', 'qt-sdk-windows-x86-mingw_opengl', 'qt-sdk-windows-x86-msvc2010_opengl', 'qt-sdk-windows-x86-msvc2012_opengl', 'qt-sdk-windows-x86-msvc2013', 'qt-sdk-windows-x86-msvc2013_opengl', 'qt-sdk-windowsrt-x86', 'qt-sdk', 'qt-vs-addin5', 'qtbinpatcher-x64', 'qtbinpatcher-x86', 'qupzilla', 'redeclipse', 'revouninstallerpro', 'rmprepusb', 'rollbackrx', 'sanerpersonal', 'simplesystemtweaker', 'smartftp', 'softwareinformer', 'songr', 'sonyvegaspro', 'sopcast', 'speedfan', 'spiceworks', 'spideroak', 'spybot', 'startisback', 'startisbackplus', 'startmenu8', 'startmenureviver', 'sumo', 'sundance', 'superantispyware', 'systemninja', 'tdesktop', 'tiggit', 'time4popcorn', 'tinycad', 'tinytask', 'trillian', 'tuneuputilities', 'ultraiso', 'unity', 'unity4', 'unitywebplayer', 'usbit', 'ut-client', 'ut-launcher', 'ut-server', 'viber', 'wassapp', 'waterfox', 'webpi', 'win-youtube-dl', 'wincontig', 'windows-tweaker', 'windowsessentials', 'windowsrepair', 'winlockless', 'winrar', 'workcad', 'xonotic', 'xvst', 'zona'] } }

@ferventcoder
Copy link
Contributor Author

@Redsandro Did you happen to see this? https://github.com/chocolatey/chocolatey.org/pull/152

@Redsandro
Copy link
Contributor

Nope, Hadn't seen it yet. But the DB solution requires 1 action in stead of 203 actions.

Here is the PR that starts the rest of the process: #46

@majkinetor
Copy link
Contributor

I think this should be closed. Too my time has passed and those packages must be rewritten to new standards and to use AU. Its almost the same as starting from the beginning.

What do you think @ferventcoder and @gep13 .

@gep13
Copy link
Member

gep13 commented Nov 13, 2016

Yes, I think I agree with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants