Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(vcredist2008) Garbage in the root drive #724

Closed
majkinetor opened this issue May 12, 2017 · 19 comments · Fixed by #732
Closed

(vcredist2008) Garbage in the root drive #724

majkinetor opened this issue May 12, 2017 · 19 comments · Fixed by #732
Labels

Comments

@majkinetor
Copy link
Contributor

This is what I have on all my computers after vcredist is installed which is highly annoying. The install.exe starts vcredist 2008 setup.

I believe the package is this one: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/_output/vcredist2008/9.0.30729.6161

@jberezanski, would it be possible for you to move it here and fix this ?

PS: ls c:\

-a----       2007-11-07     07:00          17734 eula.1028.txt
-a----       2007-11-07     07:00          17734 eula.1031.txt
-a----       2007-11-07     07:00          10134 eula.1033.txt
-a----       2007-11-07     07:00          17734 eula.1036.txt
-a----       2007-11-07     07:00          17734 eula.1040.txt
-a----       2007-11-07     07:00            118 eula.1041.txt
-a----       2007-11-07     07:00          17734 eula.1042.txt
-a----       2007-11-07     07:00          17734 eula.2052.txt
-a----       2007-11-07     07:00          17734 eula.3082.txt
-a----       2007-11-07     07:00           1110 globdata.ini
-a----       2007-11-07     07:44         855040 install.exe
-a----       2007-11-07     07:00            843 install.ini
-a----       2007-11-07     07:44          75280 install.res.1028.dll
-a----       2007-11-07     07:44          95248 install.res.1031.dll
-a----       2007-11-07     07:44          90128 install.res.1033.dll
-a----       2007-11-07     07:44          96272 install.res.1036.dll
-a----       2007-11-07     07:44          94224 install.res.1040.dll
-a----       2007-11-07     07:44          80400 install.res.1041.dll
-a----       2007-11-07     07:44          78864 install.res.1042.dll
-a----       2007-11-07     07:44          74768 install.res.2052.dll
-a----       2007-11-07     07:44          95248 install.res.3082.dll
-a----       2007-11-07     07:00           5686 vcredist.bmp
-a----       2007-11-07     07:50        1927956 VC_RED.cab
-a----       2007-11-07     07:53         242176 VC_RED.MSI
@jberezanski
Copy link
Contributor

Yeah, I could give it a shot. At first glance, however, the package does not do anything out of the ordinary, so it will probably mean debugging the native installer to determine the way to convince it to put its temp files elsewhere.

@AdmiringWorm
Copy link
Member

Looks like this was a known bug for the vcredist 2008 installer, seems like the recommended aproach is to install vcredist 2008 SP1 which have fixed that bug.
https://support.microsoft.com/help/950683/vcredist-from-vc-2008-installs-temporary-files-in-root-directory

@jberezanski
Copy link
Contributor

OK, so according to this the package should be updated to install https://www.microsoft.com/en-us/download/details.aspx?id=26368.

@majkinetor majkinetor changed the title (vcredist) Garbage in the root drive (vcredist2008) Garbage in the root drive May 14, 2017
@majkinetor
Copy link
Contributor Author

majkinetor commented May 14, 2017

URLs I got when downloading this from MS site from the link @jberezanski provided are:

Is this safe to use, i.e. not something that will expire ?

@jberezanski
Copy link
Contributor

Yes, download.microsoft.com urls are generally stable (apart from very rare cases when MS decides to remove a download).

@majkinetor
Copy link
Contributor Author

Looks like dtgm package is already of that version. I will migrate it here just for the sake of all vcredists to be on the same place.

@majkinetor
Copy link
Contributor Author

I don't know how then, I still get the garbage in the root. Perhaps some other package depends on particular version ? If that is the case it might be good idea to unlist other versions, then those packages will fail and can be fixed to use the latest one.

@AdmiringWorm
Copy link
Member

If they depend on an exact version, they wouldn't fail as the package version is still there just not shown on the website.

@majkinetor
Copy link
Contributor Author

Then we would know that package failed and can fix it to use new version instead of adding garbage to the root. It might not be good idea tho on 2nd thought.

@majkinetor
Copy link
Contributor Author

Will reopen it until its pushed.

@majkinetor
Copy link
Contributor Author

Should I push this with 9.0.30729.6162? (added +1) or something else ?

@AdmiringWorm
Copy link
Member

AdmiringWorm commented May 22, 2017

Personally I would probably add 01 (ie 9.0.30729.616101) to the existing version (using zero a separator between version and fix), but considering the redistributable will unlikely ever be updated again I'm fine with either way.

@jberezanski
Copy link
Contributor

A minor issue - tags contain "2017" instead of "2008".
Just checked installing interactively on a Win7-32 VM, no garbage. According to logs (%TEMP%\dd_vcredist*.txt) the files got extracted to C:<a_directory_name_which_looks_like_a_guid> and that directory was removed at the end of install.
Will check via choco now.

@majkinetor
Copy link
Contributor Author

Thx, fixed tag.

@jberezanski
Copy link
Contributor

choco 0.10.3 on Win7-32 - no garbage
choco 0.10.3 and 0.10.5 on Win10.1607-64 - no garbage (also when installed as dependency of vcredist-all)
@majkinetor perhaps it's something specific to your setup that causes this - custom permissions on C:? antivirus?

@majkinetor
Copy link
Contributor Author

nah, several different machines.

@majkinetor
Copy link
Contributor Author

OK, will close this and leave package unpushed for now. Will try to determine more precise how this happen and eventually reopen this.

@mmikeww
Copy link

mmikeww commented Oct 28, 2017

I just got this too. WTF. I'm wondering if chocolatey is more trouble than its worth. I've definitely spent more time 'learning' and configuring than it would have taken to simply download the installers myself. XKCD comes to mind.

edit/ found it was the choco install winmerge that's causing it.

@majkinetor
Copy link
Contributor Author

I am using winmerge too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants