-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(freecad) Updated to remove files and dev version issues #1948
Conversation
Added `freecadMinor` for updating the minor version number should it not be processed with logic
✅ Package verification completed without issues. PR is now pending human review |
@AdmiringWorm |
@RedBaron2 Are you gonna open a new Merge request or will freecad stay broken? |
I'll be opening a new PR soon |
IMO while we work on the dev releases at least the portion removing the zip files should be merged so we can get the stable update in |
script to work better
I'm re-opening this PR after help from @adrianinsaval in approving versioning issues. |
✅ Package verification completed without issues. PR is now pending human review |
1 similar comment
✅ Package verification completed without issues. PR is now pending human review |
@AdmiringWorm |
Also, it would be great if you could add yourself to the Do note that this file will be used going forward for who to request pull requests from. |
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
Added name for freecad
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
I don't know what is going on to cause appveyor to crash the AU updating with I'm going to Start a new PR and see if appveyor likes those changes |
@AdmiringWorm |
@gep13 @AdmiringWorm @luzpaz @adrianinsaval
Description
This will fix the package from trying to push as a embedded package as it is not an embedded package. It happened because I forgot to update for removing the
zip
files. This will also allow for direct updating of the dev minor version as a separate variable from the update script. This will only be needed if the update helper logic fails.Motivation and Context
This will fix issue #1941
How Has this Been Tested?
Intranet and appveyor
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist:
Original Location