(spotify) Remove Windows Store version

[pauby]

Description

Detects and removes the Windows Store version of Spotify if it's already installed and the --force option is used. Warn otherwise.

Motivation and Context

If the Windows Store version is installed, the package will not install.

How Has this Been Tested?

Run in Windows 10 with the Microsoft Store version of Spotify installed.

Screenshot (if appropriate, usually isn't needed):

Run without the --force option.

Run with the --force option:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Migrated package (a package has been migrated from another repository)

Checklist:

• My code follows the code style of this repository.
• My change requires a change to documentation (this usually means the notes in the description of a package).
• I have updated the documentation accordingly (this usually means the notes in the description of a package).
• I have updated the package description and it is less than 4000 characters.
• All files are up to date with the latest Contributing Guidelines
• The added/modified package passed install/uninstall in the chocolatey test environment.
• The changes only affect a single package (not including meta package).

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[pauby]

AppVeyor is failing for to a time out after running the scheduled task. I didn't changed this part of the code so I'm going to assume it's normal?

[AdmiringWorm]

IMO, we should not remove the Microsoft Store application in this package.

It is still two different applications, which goes against having one software for each package.

IMO, I think we should throw an exception instead, no matter what, possibly with details on how the user can uninstall the application manually or add a new package that only has the purpose of removing the Store version of Spotify (that we possibly can depend on in this package).

[pauby]

A package parameter? Warn them but if they add the package parameter it also uninstalls. Seems like the best of both worlds.

[AdmiringWorm]

hmm. Add it behind a package parameter 🤔.

Yeah, could work as well. Let's go with that instead. I still do think a separate package could be beneficial though, but we can go with the parameter for now.

[AdmiringWorm]

Please fix the indentation used on the lines changed to follow the editor config file.
The editor config file specifies that indentations should only be two spaces.

[pauby]

The indentation is inconsistent. I'll update the file to match 2 spaces.

[AdmiringWorm]

AppVeyor is failing for to a time out after running the scheduled task. I didn't changed this part of the code so I'm going to assume it's normal?

I'm honestly not sure. It could be that appveyor doesn't allow scheduled tasks to be created...

[github-actions]

Dear contributor,

As this PR seems to have been inactive for 30 days after changes or additional information
was requested, I've automatically closed it.
If you feel the changes are still valid, please re-open the PR once all changes or additional information
that was requested has been added.
Thank you for your contribution.

[pauby]

I've reopened this PR as I simply haven't had time to work on it.

[AppVeyorBot]

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

[corbob]

AppVeyor is failing for to a time out after running the scheduled task. I didn't changed this part of the code so I'm going to assume it's normal?

For what it's worth, I attempted to install the version of this package in CCR, and it seemed to do that same thing for me, as soon as I manually uninstalled the Spotify store app, then it didn't timeout and installed without issue. Depending on what AppVeyor is using, this could be the same thing (I would have thought it'd be on a Server OS without the Store, but maybe not 🤷 )

[AdmiringWorm]

AppVeyor is failing for to a time out after running the scheduled task. I didn't changed this part of the code so I'm going to assume it's normal?

For what it's worth, I attempted to install the version of this package in CCR, and it seemed to do that same thing for me, as soon as I manually uninstalled the Spotify store app, then it didn't timeout and installed without issue. Depending on what AppVeyor is using, this could be the same thing (I would have thought it'd be on a Server OS without the Store, but maybe not 🤷 )

It is reporting that it is running on Microsoft Windows Server 2016 Datacenter (https://ci.appveyor.com/project/chocolateycommunity/chocolatey-packages/builds/48351047#L134). So it shouldn't be a problem with the Windows Store. It may be possible that Spotify does not run on a Server, or it only supports the absolute latest (I honestly do not know).