Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(sqlite) Handle updated filenames and 64-bit tools #2342

Merged

Conversation

dgalbraith
Copy link
Contributor

Description

Package was failing to build due to updates in the filename format from sqlite-dll-win32-3432000.zip to sqlite-dll-win-x86-3440000.zip. The tools package has also been modified from 32-bit to 64-bit.

  • Modified filename handling in the update script to correctly process the new filename format
  • Modified the install script to handle the 64-bit tools package

Motivation and Context

The sqlite package is currently failing to build. The build is breaking as the format of the filenames used for the binary packages has changed. In addition to the filename changes the tools binary has been updated from 32-bit to 64-bit.

The update script has been modified to handle the new filename format and the install script to install the 64-bit tools package.

How Has this Been Tested?

The changes to the package build have been tested running the AU updater command $au_whatIf=$true;.\update.ps1. Prior to the changes package updates failed and they were successful following the change.

The updated package was visually inspected and the package install and upgrade tested in the Chocolatey Test Environment.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Package was failing to build due to updates in the filename format from
sqlite-dll-win32-3432000.zip to sqlite-dll-win-x86-3440000.zip.  The
tools package has also been modified from 32-bit to 64-bit.

Modified filename handling in the update script to correctly process the
new filename format and modified the install script to handle the 64-bit
tools package.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

pauby
pauby previously requested changes Dec 21, 2023
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes that I hope helps to keep things simple and consistent. Regular expressions in particular are a black art to most people.

automatic/sqlite/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/tools/chocolateyInstall.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/update.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/update.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/update.ps1 Outdated Show resolved Hide resolved
automatic/sqlite/update.ps1 Outdated Show resolved Hide resolved
* Use of Get-Item is not permitted so updated to use full filenames
* Updated error message for grammatical correctness
* Reverted regular expressions to common formats
* Set filename for Tools64 when retrieving checksum
* Reverted to prior handling for version retrieval and file detection
sans complex regex
* Improved readability by splitting code across multiple lines
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Contributor

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me when tested, and looks good! Thank you for making all of those changes, and getting this sorted.

@JPRuskin JPRuskin dismissed pauby’s stale review June 13, 2024 11:10

Checked that all comments were resolved, checked that Pauby was happy for me to dismiss this.

@JPRuskin JPRuskin merged commit 22dc35d into chocolatey-community:master Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants