Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(winscp*) Fixing URL parsing for download #2461

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

gaelcolas
Copy link
Member

@gaelcolas gaelcolas commented Apr 23, 2024

Description

WinSCP url has changed, appending a /download to the link.
This changes updates de URL and the parsing that goes along with it.

Motivation and Context

The package was failing to update on the community repo.

How Has this Been Tested?

Lightly, as I'm on a traiin :)

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

1 similar comment
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@gaelcolas gaelcolas marked this pull request as ready for review April 23, 2024 05:55
Copy link

@Waize Waize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JPRuskin JPRuskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've tested it locally, and the packages it produces work as expected.

I'll fix up the commit messages to follow our pattern (if that's okay), and then it should be good to merge!

@JPRuskin JPRuskin changed the title Fixing URL parsing for download (winscp*) Fixing URL parsing for download Apr 23, 2024
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@JPRuskin JPRuskin merged commit edab566 into chocolatey-community:master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants