Add check for background service #382
Conversation
Also fix a few typos and back resources.
|
/cc @ferventcoder |
|
Had a change to poke at this @ferventcoder? |
|
I did, but there is an issue I am going to dive deeper into this week to see whether it stems from this or from the API. |
RichiCoder1
added
the
Feature
* develop: (43 commits) Del "a" typo Correct name Christiaan Add missing Resources.sv.Designer.cs (GH-396) Localizate to Swedish Remove unused resource strings Make it possible to localizate On and Off in Settings view Set indent size for XAML. Fix build errors. (GH-372) Dynamically select open port for subprocess Reverted changes for GoodbyeDetails Fixed CodeFactor issues (GH-405) Changed Pin Button to correct resource string (GH-405) Extracted C# user displayed text (GH-405) Added missing string bindings (GH-405) Added missing strings Fix typo (GH-393) Corrected hard-coded path (GH-394) Corrected path to assets folder (maint) Corrected link to documentation site (doc) Minor copy editing ... # Conflicts: # Source/ChocolateyGui/Bootstrapper.cs # Source/ChocolateyGui/Properties/Strings1.Designer.cs # Source/ChocolateyGui/Resources/Controls.xaml # Source/ChocolateyGui/Services/ChocolateyRemotePackageService.cs # Source/ChocolateyGui/ViewModels/SourcesViewModel.cs # Source/ChocolateyGui/Views/PackageView.xaml
- Added necessary UI elements - Updated model classes with new properties - Need to wait on updated Chocolatey Lib in order to fully test
|
bump |
|
Gary and I looked deeper into this - what is happening is the licensed.dll seems to run into an error that is super hard to determine - may need to find a way to attach a debugger. What I think it is - because the licensed edition takes a dependency on choco.exe, it's having issues when it is the DLL instead. |
|
Odd. Let me know how I can assist. I believe the chocolatey.lib includes symbols right? Even if not, you should be able to switch Gui's reference to a locally build version, turn off exact source match in debug settings, and then just attached a debugger with Edit: Looks like ILMerge does the right thing, so you should still be able to debug against the merged dll. |
|
bump |
|
There have been some fixes into chocolatey.lib and the extension that may fix this. Getting ready to try this again. |
|
Excellent! I'd merge mainline develop into this as it just updated all the the packages (including lib) |
|
Can I push to this PR? |
|
Absolutely |
|
Should I wait until we get #438 through? I prefer to reduce merge conflicts and so much has changed. |
|
#438 is merged and cleaned up. You should be good to go now. |
|
Brought this branch back up to Develop. Builds and runs just fine, though I'm not sure how much of the BP functionality is still preserved. |
|
BP? |
|
Background service stuff. BS doesn't have the same ring haha. |
|
Ah true! |
|
Superseded by #451 |
Also fix a few typos and back resources.
Closes #371