Skip to content

Commit

Permalink
(#2465) Revert correction to spelling mistake
Browse files Browse the repository at this point in the history
This particular spelling mistake is on a public method, which can (and
is) used in some upstream projects.  As such, we would have to regard
this change as a breaking change, and it would have to go out as a
major release of Chocolatey.  This is not currently happening,
therefore we need to revert this change, and re-add this change in a
future release.
  • Loading branch information
gep13 committed Jul 29, 2022
1 parent 9a26e37 commit 67190e5
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ public static void extract_text_file_from_assembly(IFileSystem fileSystem, IAsse
/// <param name="overwriteExisting">
/// if set to <c>true</c> [overwrite existing].
/// </param>
/// <param name="throwError">Throw an error if there are issues</param>
public static void extract_binary_file_from_assembly(IFileSystem fileSystem, IAssembly assembly, string manifestLocation, string filePath, bool overwriteExisting = false, bool throwError = true)
/// <param name="throwEror">Throw an error if there are issues</param>
public static void extract_binary_file_from_assembly(IFileSystem fileSystem, IAssembly assembly, string manifestLocation, string filePath, bool overwriteExisting = false, bool throwEror = true)
{
if (overwriteExisting || !fileSystem.file_exists(filePath))
{
Expand All @@ -78,10 +78,10 @@ public static void extract_binary_file_from_assembly(IFileSystem fileSystem, IAs
fileSystem.write_file(filePath, () => assembly.get_manifest_stream(manifestLocation));
},
errorMessage:"Unable to extract binary",
throwError: throwError,
throwError: throwEror,
logWarningInsteadOfError: false,
logDebugInsteadOfError: !throwError,
isSilent: !throwError);
logDebugInsteadOfError: !throwEror,
isSilent: !throwEror);
}
}

Expand Down

0 comments on commit 67190e5

Please sign in to comment.