(#23) Move call to SetRemotePackageNamesIfAllSpecified

The SetRemotePackageNamesIfAllSpecified method HAS to be called AFTER
the call to GetRemoteRepositories.

In that method, the Sources on the configuration object are expanded to
be the full source URL's, rather than the named sources from the
chocolatey.config file, i.e. https://community.chocolatey.org/api/v2/
rather than simply "chocolatey".

This is important, since the full URL is what is used to ensure that a
"choco install all" is not being attempted against one of the
configured public sources.

This wasn't picked up during the initial PR review, but it was picked
up during manual testing, and this commit is the output of that manual
testing.

src/chocolatey/infrastructure.app/services/NugetService.cs

@@ -510,8 +510,6 @@ public void InstallDryRun(ChocolateyConfiguration config, Action<PackageResult,
             _fileSystem.EnsureDirectoryExists(ApplicationParameters.PackagesLocation);
             var packageResultsToReturn = new ConcurrentDictionary<string, PackageResult>(StringComparer.InvariantCultureIgnoreCase);
 
-            SetRemotePackageNamesIfAllSpecified(config, () => { });
-
             NuGetVersion version = !string.IsNullOrWhiteSpace(config.Version) ? NuGetVersion.Parse(config.Version) : null;
             if (config.Force)
             {
@@ -520,6 +518,14 @@ public void InstallDryRun(ChocolateyConfiguration config, Action<PackageResult,
 
             var sourceCacheContext = new ChocolateySourceCacheContext(config);
             var remoteRepositories = NugetCommon.GetRemoteRepositories(config, _nugetLogger, _fileSystem);
+
+            // The following method HAS to be called AFTER the call to GetRemoteRepositories.
+            // In that method, the Sources on the configuration object are expanded to be the full source URL's, rather than the named
+            // sources from the chocolatey.config file, i.e. https://community.chocolatey.org/api/v2/ rather than simply "chocolatey".
+            // This is important, since the full URL is what is used to ensure that a "choco install all" is not being attempted against
+            // one of the configured public sources in the following method.
+            SetRemotePackageNamesIfAllSpecified(config, () => { });
+
             var remoteEndpoints = NugetCommon.GetRepositoryResources(remoteRepositories, sourceCacheContext);
             var localRepositorySource = NugetCommon.GetLocalRepository();
             var pathResolver = NugetCommon.GetPathResolver(_fileSystem);