Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: Add '--no-color' as a global option and 'logWithoutColor' feature #100

Closed
ferventcoder opened this issue Feb 12, 2015 · 6 comments
Closed

logging: Add '--no-color' as a global option and 'logWithoutColor' feature #100

ferventcoder opened this issue Feb 12, 2015 · 6 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Priority_LOW
Milestone
0.10.9

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Feb 12, 2015 •
edited

For logging, allow logging without color.
@ferventcoder ferventcoder added this to the 0.9.10 milestone Feb 12, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.10.x May 20, 2015
@cobrabr
Copy link

cobrabr commented Aug 18, 2015

@ferventcoder -- quick question related to colors: is it possible to include an option somewhere to remove the -NoProfile command-line parameter from the PowerShell calls?

I'm using a different color scheme on my Command Prompt (I'm using ConEmu), and because of that, using PowerShell's default color scheme makes the progressbar almost invisible -- something I fixed by changing the colors on my profile config. Before the new Choco, I used to edit chocolatey.cmd and remove the -NoProfile from the powershell.exe call, but now I can't do that anymore... :)

Thanks!

@ferventcoder
Copy link
Member Author

@cobrabr It might be. Here's the rub - I'm removing calling PowerShell as an external process completely. See #8.

I'm also using ConEmu. :)

@ferventcoder
Copy link
Member Author

@cobrabr what this means is that the progress bar will no longer be the one you see, but a better one implemented right in line. Something closer to what you see with brew.

@cobrabr
Copy link

cobrabr commented Aug 20, 2015

@ferventcoder Oh... I guess that solves it. 😄 I'll wait for the Powershell-less version, then.

@ferventcoder ferventcoder mentioned this issue Feb 12, 2018
Closed
@ferventcoder
Copy link
Member Author

#1378 has a good workaround on this.

@ferventcoder ferventcoder modified the milestones: 0.10.x, 0.10.9 Feb 12, 2018
@ferventcoder ferventcoder self-assigned this Feb 12, 2018
@ferventcoder ferventcoder changed the title Add no color as a global option Add --no-color as a global option and logWIthoutColor feature Feb 12, 2018
@ferventcoder
Copy link
Member Author

This is good to go for v0.10.9.

@ferventcoder ferventcoder changed the title Add --no-color as a global option and logWIthoutColor feature Add --no-color as a global option and logWithoutColor feature Feb 12, 2018
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 20, 2018
@ferventcoder
(chocolateyGH-100) add no color log4net config files
b67aae0
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 20, 2018
@ferventcoder
(chocolateyGH-100) add no color feature/option
b1976d3
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 20, 2018
@ferventcoder
(chocolateyGH-100) Log without colorization
d226c57 
When a user has selected `--no-color` or has turned on the feature
`logWithoutColor`, use the console appenders in the no color options.
Note this does require checking the configuration the first time so
this can be set.
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
(GH-100) add no color log4net config files
39e9859
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
(GH-100) add no color feature/option
5697224
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
(GH-100) Log without colorization
1ec244c 
When a user has selected `--no-color` or has turned on the feature
`logWithoutColor`, use the console appenders in the no color options.
Note this does require checking the configuration the first time so
this can be set.
ferventcoder added a commit that referenced this issue Feb 20, 2018
@ferventcoder
Merge branch 'stable'
cdf0938 
* stable: (35 commits)
  (GH-1478) Upgrade 7z to 18.1
  (GH-1490) Remove quotes/apostrophes surrounding parameter
  (maint) virtualize get_package_information
  (maint) virtualize all calls in NuGetService
  (GH-100) Log without colorization
  (GH-100) add no color feature/option
  (GH-100) add no color log4net config files
  (maint) formatting
  (#1489) Log PowerShell contents w/out formatting
  (maint) Some options could be achieved w/FOSS
  (maint) Add instructions for strong naming NuGet
  (maint) update licensing code
  (GH-1488) License validation logging
  (specs) add pack scenario nuspec
  (maint) Whitespace changes
  (GH-1500) Disable re-validation of Chocolatey License File
  (doc) update etiquette statement
  (build) allow builds with any .NET 4.x
  (doc) update licensed changelog
  (maint) update licensing
  ...

# Conflicts:
#	README.md
@ferventcoder ferventcoder changed the title Add --no-color as a global option and logWithoutColor feature logging: Add '--no-color' as a global option and 'logWithoutColor' feature Mar 4, 2018
@ferventcoder ferventcoder mentioned this issue Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Priority_LOW
Projects
None yet
Milestone
0.10.9
Development

No branches or pull requests
3 participants
@ferventcoder @cobrabr @gep13