Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commandExecutionTimeout of zero means never time out #1202

Closed
ferventcoder opened this issue Mar 14, 2017 · 0 comments
Closed

commandExecutionTimeout of zero means never time out #1202

ferventcoder opened this issue Mar 14, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

Allow setting to zero as a way of saying do not time out. This goes along with #1059.
@ferventcoder ferventcoder self-assigned this Mar 14, 2017
@ferventcoder ferventcoder added this to the 0.10.4 milestone Mar 14, 2017
ferventcoder added a commit that referenced this issue Mar 15, 2017
@ferventcoder
(GH-1202) Allow 0 for infinite timeout
83307de 
Allow passing zero for execution timeout as a way of saying never
timeout.
ferventcoder added a commit that referenced this issue Mar 15, 2017
@ferventcoder
(GH-1059) Fix: Unable to change command execution timeout
b0a58f0 
When determining whether to use the default timeout, use the locally
set variable instead of using a deprecated config settings value.
Previously, when the deprecated value was set to "0" (the default), it
would not allow setting an execution timeout to anything other than the
default timeout of 2700. This has caused issues in newer installations
of Chocolatey (not upgraded) as the value of 0 would not allow changing
the execution timeout. It was looking at the deprecated timeout instead
of what was currently set or what was in the actual configuration value.

Fix this to look at the locally set variable that has already
determined what the setting is and whether it evaluates to 0 (not able
to parse or empty).

However, also allow for an actual setting of "0", which means never
time out (GH-1202) by looking at the string value prior to parsing to
see if it was set to zero.
ferventcoder added a commit that referenced this issue Mar 15, 2017
@ferventcoder
Merge branch 'stable'
628b4a7 
* stable:
  (GH-1042) Ensure-Permissions fails when run as SYSTEM
  (build) ensure build is on .NET 4.0
  (maint) remove test console logging
  (maint) rename searchTerm variable
  (maint) update nuget.core
  (GH-1059) Fix: Unable to change command execution timeout
  (GH-1059) Clean up commandExecutionTimeout setting
  (maint) clean up CacheLocation
  (GH-1202) Allow 0 for infinite timeout
  (GH-1059) Deprecate old config elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13