Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Make log4net dependency less restrictive #1395

Closed
sxmanton opened this issue Aug 29, 2017 · 2 comments
Closed

[API] Make log4net dependency less restrictive #1395

sxmanton opened this issue Aug 29, 2017 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released API Improvement
Milestone
0.10.8

Comments

@sxmanton
Copy link

The dependency is currently set as a strict requirement of = v2.0.3.

I'm blocked on some work trying to use the API in conjunction with other package with higher version dependencies of log4net. If there's no reason for it to be specifically v2.0.3, please change the dependency to a >= v2.0.3 instead.

Thanks!
@ferventcoder ferventcoder self-assigned this Aug 29, 2017
@ferventcoder ferventcoder added this to the 0.10.8 milestone Aug 29, 2017
@ferventcoder
Copy link
Member

Thanks for logging this. There used to be a strict reasoning behind these things with log4net, but with newer versions using the same signing key it should no longer be an issue.

@ferventcoder
Copy link
Member

This is completed for 0.10.8.

@ferventcoder ferventcoder changed the title [API] Please make log4net dependency less restrictive [API] Make log4net dependency less restrictive Aug 29, 2017
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
(GH-1395) API - dependency log4net >= 2.0.3
b709dc3 
Make the log4net dependency less restrictive. Previously, it had a
strict dependency on 2.0.3. Open that up for newer versions with
bindingRedirects in software that would use the API.
ferventcoder added a commit that referenced this issue Aug 29, 2017
@ferventcoder
Merge branch 'stable'
fce2bae 
* stable:
  (GH-1347) API Fix: GetConfiguration() manipulates config
  (GH-1395) API - dependency log4net >= 2.0.3
  (GH-1396) API Fix: config output is explicitly set
  (GH-1347) API method comments for Configuration
  (maint) API -move GetConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released API Improvement
Projects
None yet
Milestone
0.10.8
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @sxmanton