New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to work with different quoting styles that worked in previous client #141
Comments
I almost went out the door with scripts that are now broken due to this. This isn't just when referencing the current location, but when specifying ANY source. |
I think this was not intentional, as far as I understand this is just the way Windows deals with cmd inputs. It seems to be different if the target is a posh-script |
@ryanroundhouse this is a breaking change, not necessarily intentional. What did you have before? We can attempt to bring about something that will allow this to work with new choco. |
The problem here is we removed a bunch of layers. Before it was shim -> cmd -> powershell (jumping through hoops to ensure quotes made it all the way down). Now it is just shim -> exe. |
I was using the same thing as thigg. The documentation he linked to suggested using apostrophes around paths (ie: 'c:\program files (x86)\path\to local\store;http://chocolatey.org/api/v2/'). It now complains that the package cannot be found and it is checking: |
Would be nice to be backward compatible, also for scripts which are using chocolatey. |
agreed. Adjusted. this should be 0.9.9.1 |
So it should allow "test" 'test' and '"test'" (single, double and combined)? |
Also keep in mind that we can only do so much here. There is a difference between how powershell handles and how cmd handles it. |
In some places we've already tried to cover that - powershell may have never handled single quotes. |
But if the target is an exe file, we should be able to do the whole formatting as we like it, right? |
It should work as much the same way as before - I think the |
I was using apostrophe, not a tick. On Tue, Mar 3, 2015 at 1:49 PM, Rob Reynolds notifications@github.com
|
Yeah sorry, I use those terms interchangeably (and technically incorrectly) meaning apostrophe. Backtick being something different. |
When command has an option passed in with surrounding apostrophes, e.g. `--some-param='some value'`, remove the apostrophes from the value.
So chocolatey will properly handle apostrophes again. |
The currently working method to use the current path is "%cd".
At least here:
https://github.com/chocolatey/choco/wiki/CreatePackages#testing-your-package
The documentation suggestes '%cd%'
*From Rob: * Some of the documentation was plain wrong and leaned towards cmd.exe - single tick marks have probably never worked in powershell.exe that I'm aware of. That's why the
'"stuff"'
(apostrophe followed by a double quote) in some parts of the documentation.The text was updated successfully, but these errors were encountered: