Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninstall-ChocolateyZipPackage is unable to find zip contents file #1415

Closed
berndb84 opened this issue Oct 4, 2017 · 4 comments
Closed

Uninstall-ChocolateyZipPackage is unable to find zip contents file #1415

berndb84 opened this issue Oct 4, 2017 · 4 comments
Assignees
@gep13
Labels
5 - Released Bug Priority_HIGH
Milestone
0.10.9

Comments

@berndb84
Copy link

berndb84 commented Oct 4, 2017

What You Are Seeing?

In Install-ChocolateyZipPackage line 202 the zip file is renamed from $packageName to ($packageName)Install.zip
$downloadFilePath=Join-Path$tempDir"$($packageName)Install.$fileType"

Get-ChocolateyUnzip adds a new textfile with this ($packageName)Install.zip filename in line 121
$zipExtractLogFullPath= Join-Path $packagelibPath $zipFilename.txt`

If you now want to uninstall the zip paket, the Uninstall-ChocolateyZipPackage function is only looking for $packageName.txt (line 67) to remove all installed files.
$zipContentFile=(join-path $packagelibPath $zipFileName) + ".txt"

That doesn't work, because there is no Textfile with this name
@ferventcoder
Copy link
Member

Looks like a bug.

@ferventcoder ferventcoder added this to the 0.10.9 milestone Nov 3, 2017
@ferventcoder ferventcoder mentioned this issue Nov 3, 2017
Closed
@ferventcoder ferventcoder mentioned this issue Jan 23, 2018
Closed
@ferventcoder ferventcoder changed the title File renamming in Install-ChocolateyZipPackage File renaming in Install-ChocolateyZipPackage Jan 23, 2018
@ferventcoder ferventcoder mentioned this issue Jan 27, 2018
Open
gep13 added a commit to gep13/choco that referenced this issue Feb 23, 2018
@gep13
(chocolateyGH-1415) Added additional check for zip content file
67d4ad1 
- Check for the existence of the Install.txt file
- If that doesn't exist, fall back to the old filename
- Delete all files in content file as before
@gep13 gep13 mentioned this issue Feb 23, 2018
Merged
ferventcoder added a commit that referenced this issue Feb 26, 2018
@ferventcoder
Merge pull request #1509 from gep13/issue-1415
96522e4 
(GH-1415) Correct issue with remove zip file contents
ferventcoder added a commit that referenced this issue Feb 26, 2018
@ferventcoder
Merge branch 'stable'
878b8bb 
* stable:
  (GH-1505) clarify where to find invalid characters
  (GH-1415) Added additional check for zip content file
  (GH-1505) Ensure package information is escaped
  (maint) Whitespace changes
@ferventcoder
Copy link
Member

Merged into stable and will be released in 0.10.9.

@ferventcoder ferventcoder changed the title File renaming in Install-ChocolateyZipPackage Uninstall-ChocolateyZipPackage can't find zip contents file Mar 4, 2018
@ferventcoder ferventcoder changed the title Uninstall-ChocolateyZipPackage can't find zip contents file Uninstall-ChocolateyZipPackage is unable to find zip contents file Mar 4, 2018
This was referenced Mar 16, 2018
Closed
Closed
@pradeeps
Copy link

pradeeps commented Apr 4, 2018

I am not sure if the issue we are seeing is same, but we seems to be similar issue and we cannot upgrade to this version (0.10.9) as we don't have the password for proget website we have installed as the guy who did this left. Is there any possibility we can add this as a patch?

@ferventcoder
Copy link
Member

@pradeeps it seems you have bigger issues. I'd suggest maybe setting up a new proget site or contacting Inedo for support on how you can get into a site when you run into issues like this - I am sure they will have something for you, even if it is just set up another ProGet repo. HTH

@coldacid coldacid mentioned this issue Apr 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.10.9
Development

No branches or pull requests
4 participants
@ferventcoder @pradeeps @gep13 @berndb84