New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-BinRoot broken #144

Closed
ferventcoder opened this Issue Mar 3, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@ferventcoder
Member

ferventcoder commented Mar 3, 2015

No description provided.

@ferventcoder ferventcoder added this to the 0.9.9.1 milestone Mar 3, 2015

@ferventcoder ferventcoder self-assigned this Mar 3, 2015

ferventcoder added a commit to ferventcoder/choco that referenced this issue Mar 3, 2015

(chocolateyGH-144) Don't use write-output for information
Write-Output breaks a function waiting for a return value. Ugh

ferventcoder added a commit that referenced this issue Mar 3, 2015

Merge branch 'stable'
* stable:
  (version) 0.9.9.1
  (build) support fix version
  (GH-144) Don't use write-output for information
@Nilzor

This comment has been minimized.

Nilzor commented Apr 16, 2015

Why is it broken and why are you deprecating it? You don't provide a good alternative in the docs - the other being that you can install it to %ChocolateyInstall%\lib\mypackage. So the package developers are basically left with either a soon-to-be-deprecated option or one that the can use if they feel like it.

Don't you want your users to decide a default installation folder? Should it really be up to the package developer? Right now the target folders of the packages are total chaos. Either:

  • c:\program files
  • c:\program files (x86)
  • c:\tools
  • c:\chocolate\lib(..)
  • Whatever Get-BinRoot outputs
  • c:\ProgramData (when did that become a standard?)
  • Something completely different

Basically finding the executable after an installation is often a frustrating job. Most packages are not god on telling the user where it installs.

@ferventcoder

This comment has been minimized.

Member

ferventcoder commented Apr 16, 2015

@Nilzor note that it is NOT deprecated yet, but we are pre deprecating it.

@ferventcoder

This comment has been minimized.

Member

ferventcoder commented Apr 16, 2015

Basically many packages needed a get-bin root won't need it anymore so the recommendation will be to install it to the package folder since it is now stable and doesn't change. We are planning to release a new better named function called something like Get-ToolsRoot where folks can use the same idea of get-binroot that they were using before.

@ferventcoder

This comment has been minimized.

Member

ferventcoder commented Apr 16, 2015

@Nilzor it's not broken now. It was broken but fixed in the commit - please see ferventcoder@44306ef for details.

@Nilzor

This comment has been minimized.

Nilzor commented Apr 17, 2015

Ok I see, thanks for the update.

the recommendation will be to install it to the package folder

You should be clear on the recommandations to the packet devs and update the docs

@ferventcoder

This comment has been minimized.

Member

ferventcoder commented Jun 22, 2015

@Nilzor added #339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment