Remove the warning note about skipping, and instead show the warning when selecting skip

[christianrondeau]

When asking to run a PowerShell install script, the prompt looks like this:

Do you want to run the script?
 NOTE: If you choose not to run the script, the installation will
 fail.
 Skip is an advanced option and most likely will never be wanted.

 1) yes
 2) no [Default - Press Enter]
 3) skip

I suggest we do not show that NOTE, and instead ask for another confirmation when selecting skip (note that I'm using the #689 representation):

Do you want to run the script? (Yes/No/Skip): s
NOTE: The installation will fail. Skip is an advanced option and most likely will never be wanted.
Skip anyway? (Yes/No):

The message could probably also be improved a little bit.

For more details: https://groups.google.com/forum/#!topic/chocolatey/UVncL7PxXRg

(Moved from chocolatey-archive/chocolatey#691)

[ferventcoder]

👍

[christianrondeau]

So, let's see if all flows make sense. My initial suggestion in the original post means that if you skip and then press no, do you go back to the yes/no/skip?

Also, if I understand correctly, selecting no will fail the installation, rather than just cancel it? Otherwise I would change the messages.

Here is an example of what the flow could look like:

Do you want to run the script? (Yes/No/Skip): s
NOTE: Skip is an advanced option and most likely will never be wanted.
Skip anyway? (Yes/No): n
Do you want to run the script? (Yes/No/Skip): n

Note that I get rid of the "installation will fail", if my understanding that no == cancel is correct.

[ferventcoder]

No means install will fail.

On Wednesday, March 25, 2015, Christian Rondeau notifications@github.com
wrote:

So, let's see if all flows make sense. My initial suggestion in the
original post means that if you skip and then press no, do you go back to
the yes/no/skip?

Also, if I understand correctly, selecting no will fail the
installation, rather than just cancel it? Otherwise I would change the
messages.

Here is an example of what the flow could look like:

Do you want to run the script? (Yes/No/Skip): s
NOTE: Skip is an advanced option and most likely will never be wanted.
Skip anyway? (Yes/No): n
Do you want to run the script? (Yes/No/Skip): n

Note that I get rid of the "installation will fail", if my understanding
that no == cancel is correct.

—
Reply to this email directly or view it on GitHub
#183 (comment).

Rob
"Be passionate in all you do"

http://devlicio.us/blogs/rob_reynolds
http://ferventcoder.com
http://twitter.com/ferventcoder

[christianrondeau]

So, what is the difference between skip and install then? The only difference I see between both is in PowerShellServices.run_action, where there is an ExitCode set to -1... I didn't find what else it changed to the flow.

I believe this warrants better explanations (as a user, I am also confused), or a change so that you can either skip the package (no), or install it (yes) but no middle-ground.

Also, let me know if you like the workflow suggested in my last comment!

[ferventcoder]

Skip means install without running powershell. It may be better just to move it back to the option you pass during install and not something we ask. So I think (yes/no/view) - view is a different pr, no?

[ferventcoder]

Do you want to run the script? (Yes/No/Skip): n

This might be best handled as Do you want to run the script? ([y]es/[n]o): n

[christianrondeau]

Note 1: About your last comment, this would be part of #181. Note that I did that first, then looked up other console tools. Most of them just ask y/n or yes/no. The console will accept both y and yes, so I guess the visual cue is unnecessary. Let's move the discussion back in #181 for this, since the commit is already done and ready!

Note 2: For the option to optionally "view" the script, yes it is in issue #182.

So, what I understand (other than the two other PRs) is this:

1. We only say yes/no and remove skip
2. When Do not print PowerShell install/update scripts by default #182 is done, we'll have yes/no/view or yes/no/print (TBD)

So for this specific PR, we'll have:

The package xyz wants to run "chocolateyInstall.ps1"
Note: If you don't run this script, the installation will fail.
Do you want to run the script? (yes/no): n

I guess when #188 is done, we can remove that note.

Sounds good?

[ferventcoder]

Merged into stable at ccd3c65 and will be released in 0.9.9.5.