Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent usage of alternate Chocolatey installation/upgrade sources on non-Windows systems #2424

Closed
TheCakeIsNaOH opened this issue Oct 28, 2021 · 0 comments · Fixed by #2425
Closed

Prevent usage of alternate Chocolatey installation/upgrade sources on non-Windows systems #2424

TheCakeIsNaOH opened this issue Oct 28, 2021 · 0 comments · Fixed by #2425
Assignees
@TheCakeIsNaOH
Labels
5 - Released Improvement
Milestone
0.12.0

Comments

@TheCakeIsNaOH
Copy link
Member

None of the alternate sources work on non-windows systems. It would be better to disable to display a helpful error message instead of the misc error messages they currently fail with.

Both python and ruby could theoretically work on non-windows systems, although it would require some work to find/install the binary which may require #678. Either way, they should be disabled in the meantime.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 28, 2021
@TheCakeIsNaOH
(chocolatey#2424) Disable alternate sources on non-windows
a3cefba 
This throws an exception if running on a non-windows system for all sources
except for nuget. All of the alternates sources were broken, so this displays a
helpful error message instead of the misc error messages.

Later on, the python and ruby sources could theoretically be fixed to work on
non-windows.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 28, 2021
@TheCakeIsNaOH
(chocolatey#2424) Disable alternate sources on non-windows
b7fe743 
This throws an exception if running on a non-windows system for all sources
except for nuget. All of the alternates sources were broken, so this displays a
helpful error message instead of the misc error messages.

Later on, the python and ruby sources could theoretically be fixed to work on
non-windows.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Oct 28, 2021
Merged
7 tasks
@gep13 gep13 added this to the 0.12.0 milestone Nov 2, 2021
gep13 added a commit that referenced this issue Nov 2, 2021
@gep13
Merge pull request #2425 from TheCakeIsNaOH/disable-sources
9ef2c8f 
(#2424) Disable alternate sources on non-windows
@gep13 gep13 added 4 - Done and removed 3 - Review labels Nov 2, 2021
@gep13 gep13 changed the title Disable alternate sources on non-windows systems. Prevent usage of alternate Chocolatey installation/upgrade sources on non-windows systems. Jan 17, 2022
@gep13 gep13 changed the title Prevent usage of alternate Chocolatey installation/upgrade sources on non-windows systems. Prevent usage of alternate Chocolatey installation/upgrade sources on non-windows systems Jan 17, 2022
@pauby pauby changed the title Prevent usage of alternate Chocolatey installation/upgrade sources on non-windows systems Prevent usage of alternate Chocolatey installation/upgrade sources on non-Windows systems Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

(#2424) Disable alternate sources on non-windows TheCakeIsNaOH/choco
2 participants
@gep13 @TheCakeIsNaOH