New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Chocolatey correctly handles removed features when running the choco feature command #2538
Comments
AdmiringWorm
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 7, 2022
This commit updates the config settings service to store a list of supported features. This is done so we know which features we should handle without reporting to the user that the feature is not supported, and will have no effect when running Chocolatey.
9 tasks
AdmiringWorm
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 8, 2022
This commit updates the config settings service to store a list of supported features. This is done so we know which features we should handle without reporting to the user that the feature is not supported, and will have no effect when running Chocolatey.
AdmiringWorm
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 8, 2022
This commit updates the config settings service to store a list of supported features. This is done so we know which features we should handle without reporting to the user that the feature is not supported, and will have no effect when running Chocolatey.
gep13
pushed a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 8, 2022
This commit updates the config settings service to store a list of supported features. This is done so we know which features we should handle without reporting to the user that the feature is not supported, and will have no effect when running Chocolatey.
gep13
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 8, 2022
This commit updates the config settings service to store a list of supported features. This is done so we know which features we should handle without reporting to the user that the feature is not supported, and will have no effect when running Chocolatey.
gep13
added a commit
that referenced
this issue
Mar 8, 2022
…ecated-features (#2538) Store a list of supported features
gep13
changed the title
Correctly handle deprecated features
Ensure that Chocolatey correctly handles removed features when running the choco feature command
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the release of v0.12.0 we deprecated a feature. All the code for this feature was removed from the code case, however, after upgrading an installation of Chocolatey, the corresponding entry can still be found in the chocolatey.config file.
This by itself doesn't actually cause a problem, and it needs to be left in the file in order to allow for backwards compatibility, however, when executing the following command on Chocolatey v0.12.0:
It will output that the feature was enabled, when actually, nothing in the current codebase will do anything with this.
In any given Chocolatey version, we need to support only the features that exist in that release, nothing else, even though they exist in the chocolatey.config file. This is different to the config values, which are intended to be extended through Chocolatey Extensions, etc. However, features are specific to Chocolatey.
This will require an upstream modification for when the Chocolatey Licensed Extension is in play.
The text was updated successfully, but these errors were encountered: