Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choco resolves the latest version of a package, no matter what the source #279

Closed
ferventcoder opened this issue May 13, 2015 · 0 comments
Closed

Choco resolves the latest version of a package, no matter what the source #279

ferventcoder opened this issue May 13, 2015 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug FeatureParity Priority_HIGH
Milestone
0.9.9.6

Comments

@ferventcoder
Copy link
Member

It used to work that the first source with a dependency would win, no matter if that version was the latest or not.

But now it appears that the default is to resolve a dependency across all of the sources and find the highest version that meets that need.

Found and confirmed at https://gitter.im/chocolatey/choco?at=5553c013ac259d5627832090, more information provided at https://gitter.im/chocolatey/choco?at=5553c013ac259d5627832090

http://nuget.codeplex.com/SourceControl/changeset/view/eb53b345fd6245d713709fabdc06e334a2c02fde#src/Core/Repositories/AggregateRepository.cs

https://github.com/chocolatey/choco/blob/master/src/chocolatey/infrastructure.app/nuget/NugetCommon.cs#L83 would reintroduce the old behavior, but perhaps we provide the option for folks to choose what works best for them.

I think we should default to the old behavior but allow folks to move to the other - then in v1 we can switch it to the other way. Provide option to resolve dependencies across every source instead of first matching source.
@ferventcoder ferventcoder self-assigned this May 13, 2015
@ferventcoder ferventcoder added this to the 0.9.9.6 milestone May 13, 2015
@ferventcoder ferventcoder changed the title Provide option to resolve dependencies vertically Choco resolves the latest version of a package, no matter what the source May 13, 2015
This was referenced May 16, 2015
Open
Open
ferventcoder added a commit that referenced this issue May 16, 2015
@ferventcoder
(GH-279) Resolve packages on first feed found
f3e2084 
For aggregate repositories, packages are supposed to be resolved on the
first feed it is found on in priority order, no matter if it is the
latest version of that package or not. This is how it worked in 0.9.8.x
and below and how it should work until v1 when we can switch the
default. This fixes the behavior to be what is expected.
ferventcoder added a commit that referenced this issue May 16, 2015
@ferventcoder
Merge branch 'stable'
9417a5b 
* stable:
  (doc) update changelog / nuspec
  (GH-265) Mention how to auto confirm prompts
  (GH-279) Resolve packages on first feed found
  (maint) formatting
  (GH-271) Replace /I with /X on uninstall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug FeatureParity Priority_HIGH
Projects
None yet
Milestone
0.9.9.6
Development

No branches or pull requests
2 participants
@ferventcoder @gep13