Infinite loop downloading files if connection is lost

[bill-long]

Starting on line 110 in Get-WebFile.ps1, there is a loop that reads from the stream:

do
{
   $count = $reader.Read($buffer, 0, $buffer.Length);
...
} while ($count -gt 0)

If the first Read() succeeds, $count will contain a value greater than 0. However, if Read() then starts throwing exceptions due to loss of connection, $count will not be updated and the loop will be repeated forever. This results in the following error, over and over again:

 Exception calling "Read" with "3" argument(s): "Unable to read data from the tr
 ansport connection: Ein Verbindungsversuch ist fehlgeschlagen, da die Gegenstel
 le nach einer bestimmten Zeitspanne nicht richtig reagiert hat, oder die herges
 tellte Verbindung war fehlerhaft, da der verbundene Host nicht reagiert hat."
 At C:\ProgramData\chocolatey\helpers\functions\Get-WebFile.ps1:112 char:8
 +        $count = $reader.Read($buffer, 0, $buffer.Length);
 +        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
     + FullyQualifiedErrorId : IOException

Simplest fix is probably just:

do
{
   $count = 0
   $count = $reader.Read($buffer, 0, $buffer.Length);
...
} while ($count -gt 0)

Edit: On second thought, that would break out of the loop but it would also make it appear that Get-WebFile succeeded. This should probably be a fatal error.

[ferventcoder]

This was seen filling up someone's drive at https://chocolatey.org/packages/poweriso#comment-2110611483

[GillesJ]

This issue caused two .zip installation files to fill my drive: one was 90GB (for the Eclipse package) and another of 15GB. My internet connection is wonky and often cuts out, so it's probably due to this loss of connection bug.

[ferventcoder]

This has been fixed for 0.9.9.9.