License Validation outputs some errors and warnings when limit-output enabled.

[corbob]

What You Are Seeing?

When running a command with --limit-output, the License Validation will sometimes output errors and warnings.

What is Expected?

Chocolatey License Validation should not output unless absolutely necessary.

How Did You Get This To Happen? (Steps to Reproduce)

1. Create a license directory in your Chocolatey install
2. Add a file to the license directory (named something that is not chocolatey.license.xml
3. Run choco list -lo --limit-output
4. Observe the error and warning text about there not being a license, but about the license directory not being empty.

System Details

• OS Build: Windows Server 2019
• Windows PowerShell version: 5.1
• Chocolatey version: 1.1.0

Output Log

N/A

[corbob]

Some context for anyone that might pick this up, I thought initially that this might be as simple as adding a check for regular output, but without debugging, it looks like a large portion of this is fixed by assessing the logic here:

choco/src/chocolatey/infrastructure/licensing/LicenseValidation.cs

Lines 138 to 147 in e35fe2b

	private static bool determine_if_regular_output_for_logging()
	{
	var args = Environment.GetCommandLineArgs();
	if (args == null || args.Length < 2) return true;
	var firstArg = args[1].to_string();
	if (firstArg.is_equal_to("-v") || firstArg.is_equal_to("--version")) return false;
	return true;
	}