Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect log4net version in chocolatey.lib dependencies #390

Closed
mwrock opened this issue Aug 23, 2015 · 3 comments

Comments

@mwrock
Copy link
Member

commented Aug 23, 2015

I have been building from source while testing usage of chocolatey.dll. I am able to call into it with no issue. Today I updated my build script to pull the dll from nuget.org. My script copies the chocolatey assembly along with the log4net assembly to my app directory. Now trying to instantiate types declared in the chocolatey dll yields exceptions complaining that it cannot find log4net v 1.2.13.0 which is indeed what the chocolatey assembly is compiled with. However, the chocolatey.lib nuspec declares its dependency against 1.2.10.

mwrock added a commit to mwrock/choco that referenced this issue Aug 23, 2015
This corrects the version of log4net declared in the chocolatey.lib
nuspec. changing it to 1.2.13.
mwrock added a commit to mwrock/choco that referenced this issue Aug 23, 2015
This corrects the version of log4net declared in the chocolatey.lib
nuspec. changing it to 2.0.3 which maps to assembly version 1.2.13.
ferventcoder added a commit that referenced this issue Aug 23, 2015
(GH-390) Fix log4net dependency version in nuspec
@ferventcoder ferventcoder added this to the 0.9.10 milestone Aug 23, 2015
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Aug 23, 2015

Merged into master, which means 0.9.10. If you want to target 0.9.9 series, submit against stable branch. :)

@mwrock

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2015

thats cool. I changed my build script to grab that specific log4net version s oI'm good until 0.9.10. Thanks!!

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Aug 23, 2015

Merged into master at 6b63f79

ferventcoder added a commit that referenced this issue Oct 11, 2015
* master: (61 commits)
  (version) 0.9.10-beta1
  (doc) update release notes/nuspec for 0.9.10
  (GH-431) Changed Count to ListCount. Added xml docs to List and ListCount.
  (GH-431) Add Count to IListCommand Uses the IQueryable changes to add an efficient count for retrieving the number of results that would be returned by a list, usually in a much faster, more efficient way.
  (GH-431) Update Nuget List to use IQueryable as far down as makes sense. Updated Nuget List to attempt to use IQueryable all the way down for queries executed against service based repositories. This allows chocolatey to defer filtering, sorting, and paging to the server rather than the client. Reverts back to the old logic, though, for everything else.
  (GH-433) Externalize some more package information. Externalizes more package information that was available through the API as properties, but were marked internal. Allows full access to all Package information.
  (GH-427) Add paging to ListCommand
  (GH-71) Add priority property to ChocolateySource
  (GH-416) Named arguments issue after merge
  (GH-363) Show human-readable file sizes when downloading
  (GH-392) pass 4.0 reference assemblies to ilmerge
  (GH-390) Fix log4net dependency version in nuspec
  (maint) registry specs are Windows only
  (maint) define windows only tests
  (doc) update changelog
  (version) 0.9.10-alpha series
  (GH-14) Throw when windowsfeature is not plural
  (GH-14) Log source type evaluated
  (maint) removing unused variable
  (GH-14) Allow alternative sources to interact
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.