New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only fail automation scripts (chocolateyInstall.ps1) if the script returns non-zero exit code #445
Comments
Closed
Also adding a switch and feature flag to set this back. The default behavior should be not to fail. |
ferventcoder
added a commit
to ferventcoder/choco
that referenced
this issue
Dec 23, 2015
Add a new switch and feature flag called `failOnStandardError`, that will allow the older behavior of non-terminating errors to fail a package. Otherwise log the error to stderr and give a warning message that only an exit code of 1 will fail a package without the switch.
ferventcoder
added a commit
that referenced
this issue
Dec 23, 2015
* stable: (maint) formatting (spec) Ensure MockLogger is setup first in test suite (specs) Allow for nupkgs to finish copying (specs) use deep copy for config (GH-516) Fix: Log.InitializeWith doesn't clear cached loggers (GH-445) Only fail scripts on non-zero exit code (GH-510) allow silentargs in template
This was referenced Jan 1, 2016
ferventcoder
added a commit
to ferventcoder/choco
that referenced
this issue
Jan 1, 2016
ferventcoder
added a commit
to ferventcoder/choco
that referenced
this issue
Jan 1, 2016
When running PowerShell operations, use a built-in PowerShell host by default, allowing fallback to the older method of running Posh by calling an external process. By building against the oldest version of System.Management.Automation that aligns with the oldest Windows Operating Systems supported, we can guarantee this will work on every version of Windows where Chocolatey is supported. In case we do run into issues, attempt to resolve the PowerShell assemblies starting from the newest version and falling down to the older versions until one is resolved or no version is resolved. There is a known assembly that will go through this process every time - System.Management.Automation.resources, en-US. To see those assemblies go through, one must ask for both debug and verbose output. This reverts the changes for chocolateyGH-249 in 9936876 and the changes from chocolateyGH-349 in 344268b so that both paths (system powershell and choco's built-in PowerShell) run with similar output and because by default in d523e7b (chocolateyGH-445) choco no longer fails on the presence of stderr output.
ferventcoder
added a commit
that referenced
this issue
Jan 1, 2016
* stable: (doc) update Changelog (GH-8) Use Custom PowerShell Host (GH-8) Configuration for PowerShell Host (GH-8) Implement Custom PowerShell Host (GH-8) Add System.Management.Automation binary (GH-8) Convert to SecureString (GH-8) ReadKey Timeout (GH-8) Run commands with timeout (maint) add messages to package installers (GH-8) ReadLine Timeout (GH-445) Scenario docs update (GH-520) Fix: Debug/Verbose messages not logged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://groups.google.com/d/msgid/chocolatey/32a93a60-bc15-4b26-aba2-4917c138c716%40googlegroups.com?utm_medium=email&utm_source=footer
@mjiderhamn wrote:
@ferventcoder response:
This is up for discussion.We decided to move forward on this, and leave a way to get back the former behavior. Since this was considered a bug / regression for the 0.9.9 series, the 0.9.10 series will take it as a breaking change.The text was updated successfully, but these errors were encountered: